Skip to content

Fix false negatives for Style/MapIntoArray#13174

Merged
bbatsov merged 1 commit intorubocop:masterfrom
vlad-pisanov:vp_map_into_array_1
Aug 31, 2024
Merged

Fix false negatives for Style/MapIntoArray#13174
bbatsov merged 1 commit intorubocop:masterfrom
vlad-pisanov:vp_map_into_array_1

Conversation

@vlad-pisanov
Copy link
Contributor

Improve Style/MapIntoArray to detect cases where the destination array is initialized to an empty literal in ways other than [].

dest = []            # ✔️ currently supported

dest = Array.new     # ⚠️ new offense
dest = Array[]       # ⚠️ new offense
dest = Array([])     # ⚠️ new offense
dest = Array.new([]) # ⚠️ new offense

arr.each { |x| dest << x }

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…stination using `Array[]`, `Array([])`, or `Array.new([])`
@bbatsov bbatsov merged commit a2ef5b4 into rubocop:master Aug 31, 2024
@bbatsov
Copy link
Collaborator

bbatsov commented Aug 31, 2024

Looks good to me. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants