Support AllCops:ActiveSupportExtensionsEnabled for Style/SymbolProc#12905
Merged
bbatsov merged 1 commit intorubocop:masterfrom May 16, 2024
Conversation
Follow up rubocop@d39f073. This PR supports `AllCops:ActiveSupportExtensionsEnabled` instead of a TODO comment in `Style/SymbolProc` cop.
Collaborator
|
Thanks! |
koic
deleted the
change_support_active_support_extensions_enabled_for_style_symbol_proc
branch
Contributor
|
I'm seeing a false positive here with CSV converters. They also check the arity of the proc, so auto-correcting from I was able to prevent Rubocop from reporting the offense by using the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up d39f073.
This PR supports
AllCops:ActiveSupportExtensionsEnabledinstead of a TODO comment inStyle/SymbolProccop.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.