Fix a false positive for Style/NilComparison without receiver and EnforcedStyle: comparison#12768
Merged
koic merged 1 commit intorubocop:masterfrom Mar 10, 2024
Conversation
Earlopain
force-pushed
the
fix-false-positive-for-style-nil-comparison
branch
from
12ec7a4 to
c1c128f
Compare
Contributor
Author
|
This is broken on prism 0.24. I'm assuming this is the same as all the other tests that have this comment. I confirmed that the test passes against prism main. |
koic
reviewed
Mar 10, 2024
8 tasks
Earlopain
force-pushed
the
fix-false-positive-for-style-nil-comparison
branch
from
c1c128f to
aa97673
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would previously show an offense and get into an infinite loop during correction.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.