Fix false positives for Style/ArgumentsForwarding#12578
Merged
bbatsov merged 1 commit intorubocop:masterfrom Jan 11, 2024
Merged
Fix false positives for Style/ArgumentsForwarding#12578bbatsov merged 1 commit intorubocop:masterfrom
Style/ArgumentsForwarding#12578bbatsov merged 1 commit intorubocop:masterfrom
Conversation
koic
force-pushed
the
fix_false_positives_for_style_arguments_forwarding
branch
from
daaf944 to
97d7822
Compare
Fixes rubocop#12571 (comment). This PR fixes false positives for `Style/ArgumentsForwarding` when rest arguments forwarding to a method in block.
koic
force-pushed
the
fix_false_positives_for_style_arguments_forwarding
branch
from
97d7822 to
a40d4e4
Compare
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this pull request
Jan 23, 2025
…Forwarding` with Ruby >= 3.4 when the block is referenced in a block This worked around a bug in Ruby 3.3.0, where this syntax was accidentally disallowed. This check can now be reenabled for 3.4 where all versions accept it. Reference: * rubocop#12571 * rubocop#12577 * rubocop#12578 * https://bugs.ruby-lang.org/issues/20090
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this pull request
Jan 23, 2025
…Forwarding` with Ruby >= 3.4 when the block is referenced in a block This worked around a bug in Ruby 3.3.0, where this syntax was accidentally disallowed. This check can now be reenabled for 3.4 where all versions accept it. Reference: * rubocop#12571 * rubocop#12577 * rubocop#12578 * https://bugs.ruby-lang.org/issues/20090
8 tasks
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this pull request
Jan 23, 2025
…Forwarding` with Ruby >= 3.4 when the block is referenced in a block This worked around a bug in Ruby 3.3.0, where this syntax was accidentally disallowed. This check can now be reenabled for 3.4 where all versions accept it. Reference: * rubocop#12571 * rubocop#12577 * rubocop#12578 * https://bugs.ruby-lang.org/issues/20090
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this pull request
Jan 28, 2025
…Forwarding` with Ruby >= 3.4 when the block is referenced in a block This worked around a bug in Ruby 3.3.0, where this syntax was accidentally disallowed. This check can now be reenabled for 3.4 where all versions accept it. Reference: * rubocop#12571 * rubocop#12577 * rubocop#12578 * https://bugs.ruby-lang.org/issues/20090
bbatsov
pushed a commit
that referenced
this pull request
Jan 28, 2025
…Forwarding` with Ruby >= 3.4 when the block is referenced in a block This worked around a bug in Ruby 3.3.0, where this syntax was accidentally disallowed. This check can now be reenabled for 3.4 where all versions accept it. Reference: * #12571 * #12577 * #12578 * https://bugs.ruby-lang.org/issues/20090
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12571 (comment).
This PR fixes false positives for
Style/ArgumentsForwardingwhen rest arguments forwarding to a method in block.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.