Fix false negative in Style/ArgumentsForwarding when a block is forwarded but other args aren't#12541
Merged
bbatsov merged 2 commits intorubocop:masterfrom Dec 19, 2023
Merged
Conversation
0a41f4d to
03180e7
Compare
…warded but other args aren't.
03180e7 to
7a72839
Compare
Collaborator
|
Looks good! Thanks for tackling this! |
Contributor
|
The suggested correction seems to change the method's arity, which could be the wrong thing to do. |
Contributor
|
See #12618. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following code gets registered as a false negative by
Style/ArgumentsForwardingWhich results in the following invalid autocorrection (
&blockis now longer defined):This change fixes that case by considering block arguments when determining if forwarding is possible.
This had two side effects:
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.