Fix an incorrect autocorrect for Style/RedundantDoubleSplatHashBraces#12262
Merged
bbatsov merged 1 commit intorubocop:masterfrom Oct 11, 2023
Conversation
koic
force-pushed
the
fix_incorrect_autocorrect_for_style_redundant_double_splat_hash_braces
branch
from
d0cf905 to
24e8ca5
Compare
This PR fixes the following incorrect autocorrect for `Style/RedundantDoubleSplatHashBraces`
when using double splat hash braces with `merge` method call twice.
```console
$ bundle exec rspec spec/rubocop/cop/style/redundant_double_splat_hash_braces_spec.rb:82
Run options: include {:locations=>{"./spec/rubocop/cop/style/redundant_double_splat_hash_braces_spec.rb"=>[82]}}
(snip)
Failures:
1) RuboCop::Cop::Style::RedundantDoubleSplatHashBraces registers an offense
when using double splat hash braces with `merge` method call twice
Failure/Error: expect(new_source).to eq(correction)
expected: "do_something(foo: bar, **options)\ndo_something(baz: qux, **options)\n"
got: "do_something(foo: bar, **options)\ndo_something(baz: qux.merge(options))\n"
(compared using ==)
Diff:
@@ -1,3 +1,3 @@
do_something(foo: bar, **options)
-do_something(baz: qux, **options)
+do_something(baz: qux.merge(options))
# ./lib/rubocop/rspec/expect_offense.rb:164:in `expect_correction'
# ./spec/rubocop/cop/style/redundant_double_splat_hash_braces_spec.rb:90:in `block (2 levels) in <top (required)>'
Finished in 0.15475 seconds (files took 1.24 seconds to load)
1 example, 1 failure
```
koic
force-pushed
the
fix_incorrect_autocorrect_for_style_redundant_double_splat_hash_braces
branch
from
24e8ca5 to
99e6f85
Compare
koic
deleted the
fix_incorrect_autocorrect_for_style_redundant_double_splat_hash_braces
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following incorrect autocorrect for
Style/RedundantDoubleSplatHashBraceswhen using double splat hash braces withmergemethod call twice.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.