Fix an error for Layout/EmptyLinesAroundExceptionHandlingKeywords#13172
Merged
koic merged 1 commit intorubocop:masterfrom Aug 30, 2024
Conversation
This PR fixes the following error for `Layout/EmptyLinesAroundExceptionHandlingKeywords` when `ensure` and `end` are on the same line: ```console $ cat /tmp/example.rb def do_something ensure end $ ruby -c /tmp/example.rb Syntax OK $ bundle exec rubocop /tmp/example.rb -a -d --only Layout/EmptyLinesAroundExceptionHandlingKeywords (snip) For /tmp: An error occurred while Layout/EmptyLinesAroundExceptionHandlingKeywords cop was inspecting /tmp/example.rb:1:0. The range 28...29 is outside the bounds of the source /Users/koic/.rbenv/versions/3.4-dev/lib/ruby/gems/3.4.0+0/gems/parser-3.3.4.2/lib/parser/source/tree_rewriter.rb:406: in 'Parser::Source::TreeRewriter#check_range_validity' /Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/corrector.rb:120:in 'RuboCop::Cop::Corrector#check_range_validity' ``` A similar issue can occur with `else`.
koic
deleted the
fix_error_for_layout_empty_lines_around_exception_handling_keywords
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following error for
Layout/EmptyLinesAroundExceptionHandlingKeywordswhenensureandendare on the same line:A similar issue can occur with
else.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.