Merged
Conversation
There was a bug with how we render a Python bool value into JavaScript. This PR fixes that issue. Closes #1620
agjohnson
approved these changes
Oct 31, 2024
Collaborator
agjohnson
left a comment
agjohnson
left a comment
There was a problem hiding this comment.
I didn't catch that either of these were boolean, I assumed they were query selector strings. This is where I prefer to use naming to illustration the variable use: hasVersionSelector and hasLanguageSelector are more obviously boolean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug with how we render a Python bool value into JavaScript. This PR fixes that issue.
Closes #1620