Seek past the data when skipping a PSD layer#7483
Merged
hugovk merged 1 commit intopython-pillow:mainfrom Dec 21, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7482
When reading through layers in a PSD, Pillow skips layers that have more than 4 channels.
Pillow/src/PIL/PsdImagePlugin.py
Lines 184 to 192 in a10dec0
However, when doing so, there is only a
continue. It ignores the fact that there is still data in this file relating to the current layer, that we would have started reading otherwise.This PR skips past the rest of the layer. I created a test image in GIMP, using a layer mask as the fifth channel for a layer, and then adding another layer after that.