Skip to content

[cherry-pick] Fix mypy plugin for 1.4.0 (#5927)#5928

Merged
adriangb merged 1 commit intopydantic:1.10.X-fixesfrom
cdce8p:fix-mypy-backport
Jun 1, 2023
Merged

[cherry-pick] Fix mypy plugin for 1.4.0 (#5927)#5928
adriangb merged 1 commit intopydantic:1.10.X-fixesfrom
cdce8p:fix-mypy-backport

Conversation

@cdce8p
Copy link
Contributor

@cdce8p cdce8p commented May 30, 2023 •
edited by pydantic-hooky bot
Loading

Change Summary

Cherry-pick of #5927
Adapted for 1.10.X.

Related issue number

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @PrettyWood

@cdce8p
Copy link
Contributor Author

cdce8p commented May 30, 2023

please review

@samuelcolvin samuelcolvin assigned hramezani and unassigned PrettyWood May 30, 2023
@samuelcolvin samuelcolvin added the bug V2 Bug related to Pydantic V2 label May 30, 2023
@samuelcolvin samuelcolvin added bug V1 Bug related to Pydantic V1.X and removed bug V2 Bug related to Pydantic V2 labels May 30, 2023
@cdce8p
Copy link
Contributor Author

cdce8p commented May 30, 2023

#5927 was just merged.

After this PR is merged as well, it would be awesome if 1.10.9 could be released. That would make testing mypy dev versions a bit easier.

@hramezani
Copy link
Member

hramezani commented May 31, 2023 •
edited
Loading

@samuelcolvin Do we plan to prepare a new release for 1.10.x to include this change?

If so, I can handle it.

BTW, it's ready to merge

@adriangb adriangb merged commit ca10302 into pydantic:1.10.X-fixes Jun 1, 2023
@cdce8p cdce8p deleted the fix-mypy-backport branch June 1, 2023 14:49
@cdce8p
Copy link
Contributor Author

cdce8p commented Jun 7, 2023

Any update on a 1.10.9 release? The next mypy release (which breaks the 1.10.8 plugin) is currently scheduled for early July (about a month). It would be awesome to have the fix released sooner rather than later to give people enough time to update and make the transition as painless as possible.

@samuelcolvin
Copy link
Member

samuelcolvin commented Jun 7, 2023

good idea, will do.

@tanyaaae12 tanyaaae12 mentioned this pull request Apr 25, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hramezani hramezani hramezani approved these changes

@dmontagu dmontagu dmontagu approved these changes

Assignees

@hramezani hramezani

Labels

bug V1 Bug related to Pydantic V1.X ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cdce8p @hramezani @samuelcolvin @dmontagu @adriangb @PrettyWood