Fix null coalesce assignment type - #2702
Merged
Merged
Conversation
Contributor
Author
|
Hi, I'm new to phptan-src. I created a pull request referred to several merged pull requests. Any advice is welcome. Thank you in advance. |
Member
|
Perfect, thank you very much! |
Member
|
I encourage you to look into more "easy fixes" issues (https://github.com/phpstan/phpstan/milestone/8) :) They might not be exactly "easy" to figure out, I mark issues as "easy fixes" where I'm sure it's actually fixable in the current feature set of PHPStan and doesn't require any fundamental changes or refactorings :) The rule of thumb is - if the fix takes less than 50 lines of code, you're good to go, if it takes more and is tricker than that, I probably misqualified the issue and shouldn't be marked as easy to fix :) |
Contributor
Author
|
Thank you so much for your review and advice :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: phpstan/phpstan#9995