Allow Redis::pconnect to have 7 parameters - #2695
Merged
ondrejmirtes merged 1 commit intoOct 30, 2023
Merged
Conversation
Collaborator
|
You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x. |
Member
|
I will merge this if you rebase it on top of 1.10.x. |
Vaalyn
force-pushed
the
fix-redis-pconnect-function-signature
branch
from
October 29, 2023 12:21
1218ecd to
64a0444
Compare
Contributor
Author
|
@ondrejmirtes 👍 done |
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a similar issue that was reported in phpstan/phpstan#9413 and subsequently fixed in #2442.
The
Redis::pconnectmethod also accepts 7 parameters like theRedis::connectmethod, currently using all 7 available parameters on thepconnectmethod will show the error:As can be seen here on the redis.stub.php the signature in the PHPStan function map is missing 2 parameters:
I've updated the function map to match the method signature.