Respect proper case for namespaced functions - #2673
Conversation
|
You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x. |
|
It looks like the tests on Windows aren't working because the |
|
This pull request has been marked as ready for review. |
|
Thank you, I reused your regression test but did a different and correct fix. See the commit history in this PR: 0db2317 PHPStan cannot rely on runtime reflection because it's often wrong, and PHPStan also doesn't require PHP extensions to be loaded for successful analysis. The fix I did will use the name from BetterReflection which takes it from jetbrains/phpstorm-stubs where it's correct: https://github.com/JetBrains/phpstorm-stubs/blob/master/mongodb/Monitoring/functions.php |
|
Thanks for the quick turn-around on this @ondrejmirtes! Yes, that fix looks a lot cleaner than what I came up with. I had looked through that function while investigating the bug, but hadn't spotted that the real name was retrievable from there. |
Fixes phpstan/phpstan#10003