Include redisSock's persistent_id in persistent connection pool persistent_id string#2425
Open
thor-son wants to merge 1 commit intophpredis:developfrom
Open
Include redisSock's persistent_id in persistent connection pool persistent_id string#2425thor-son wants to merge 1 commit intophpredis:developfrom
thor-son wants to merge 1 commit intophpredis:developfrom
Conversation
…stent_id string Fixes phpredis#1920
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When use dbNumber 0 and not use select command after redis connect, pconnect return already selected db redisConn.
So use persistent_id for identified redisConn. But Not work.
This issue was opened. #1920
And not match in README.md description.
phpredis/README.md
Line 291 in ff30534
All connection pool contained or not persistent_id return same persistent_id.
Of course it can be solved by using
redis.pconnect.pool_pattern, Default option users will have a hard time understanding why an issue occurs.This issue start at 5.0.0 version's commit. 8206b14