feat(misc): update status icons to rh icons#12291
Open
kmcfaul wants to merge 3 commits intopatternfly:mainfrom
Open
feat(misc): update status icons to rh icons#12291kmcfaul wants to merge 3 commits intopatternfly:mainfrom
kmcfaul wants to merge 3 commits intopatternfly:mainfrom
Conversation
kmcfaul
changed the title
WalkthroughReplaced PatternFly outline-style status/notification icons with RH UI "fill" icon variants across core helpers, components, examples, demos, tests, an icon-mapping script, and a Figma connector. No public APIs or control flow were changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
|
Preview: https://pf-react-pr-12291.surge.sh A11y report: https://pf-react-pr-12291-a11y.surge.sh |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/react-core/src/components/Button/examples/ButtonCircle.tsx (1)
16-16:⚠️ Potential issue | 🔴 CriticalMissing
useStateimport will cause a runtime error.The component uses
useStateon line 16, but there is no import statement for it. While React is available globally in this repo,useStatemust still be explicitly imported as a named export from'react'.🐛 Proposed fix
+import { useState } from 'react'; import { Button, Flex } from '@patternfly/react-core';🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/react-core/src/components/Button/examples/ButtonCircle.tsx` at line 16, The file ButtonCircle.tsx uses the React hook useState (const [isUploading, setIsUploading] = useState<boolean>(false)) but does not import it; add useState as a named import from 'react' (either by updating an existing import React, { useState } from 'react' or adding a separate import { useState } from 'react') so the useState hook is available at runtime.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/react-core/src/demos/examples/Card/CardStatus.tsx`:
- Line 218: The blue status Label in CardStatus.tsx is using RhUiErrorFillIcon
which is semantically incorrect; update the JSX where Label color="blue" and
icon={<RhUiErrorFillIcon />} to use the info icon (e.g., replace
RhUiErrorFillIcon with RhUiInfoFillIcon or the designated info icon export) so
the icon matches the blue/info status convention, and ensure you import the
chosen RhUiInfoFillIcon at the top of the file if not already imported.
In `@packages/react-core/src/demos/Tabs.md`:
- Line 8: The import for the icon uses the CommonJS path; update the
RhUiInformationFillIcon import to use the ESM package to match other imports in
this file—replace the current
'@patternfly/react-icons/dist/js/icons/rh-ui-information-fill-icon' import with
the ESM path
'@patternfly/react-icons/dist/esm/icons/rh-ui-information-fill-icon' so module
targets remain consistent (locate the import of RhUiInformationFillIcon in
Tabs.md and change its module path).
---
Outside diff comments:
In `@packages/react-core/src/components/Button/examples/ButtonCircle.tsx`:
- Line 16: The file ButtonCircle.tsx uses the React hook useState (const
[isUploading, setIsUploading] = useState<boolean>(false)) but does not import
it; add useState as a named import from 'react' (either by updating an existing
import React, { useState } from 'react' or adding a separate import { useState }
from 'react') so the useState hook is available at runtime.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: bb83a1b4-4af4-4076-ae18-61c272757df8
⛔ Files ignored due to path filters (11)
packages/react-core/src/components/Alert/__tests__/Generated/__snapshots__/AlertIcon.test.tsx.snapis excluded by!**/*.snap,!**/generated/**packages/react-core/src/components/FormSelect/__tests__/__snapshots__/FormSelect.test.tsx.snapis excluded by!**/*.snappackages/react-core/src/components/Modal/__tests__/__snapshots__/ModalBoxTitle.test.tsx.snapis excluded by!**/*.snappackages/react-core/src/components/MultipleFileUpload/__tests__/__snapshots__/MultipleFileUploadStatusItem.test.tsx.snapis excluded by!**/*.snappackages/react-core/src/components/NotificationBadge/__tests__/__snapshots__/NotificationBadge.test.tsx.snapis excluded by!**/*.snappackages/react-core/src/components/NotificationDrawer/__tests__/__snapshots__/NotificationDrawerListItemHeader.test.tsx.snapis excluded by!**/*.snappackages/react-core/src/components/NumberInput/__tests__/__snapshots__/NumberInput.test.tsx.snapis excluded by!**/*.snappackages/react-core/src/components/Progress/__tests__/Generated/__snapshots__/ProgressContainer.test.tsx.snapis excluded by!**/*.snap,!**/generated/**packages/react-core/src/components/Progress/__tests__/__snapshots__/Progress.test.tsx.snapis excluded by!**/*.snappackages/react-core/src/components/TextInput/__tests__/__snapshots__/TextInput.test.tsx.snapis excluded by!**/*.snappackages/react-core/src/deprecated/components/Modal/__tests__/__snapshots__/ModalBoxTitle.test.tsx.snapis excluded by!**/*.snap
📒 Files selected for processing (102)
packages/code-connect/components/PopOver/Popover.figma.tsxpackages/react-core/src/components/Alert/AlertIcon.tsxpackages/react-core/src/components/Alert/__tests__/AlertIcon.test.tsxpackages/react-core/src/components/Banner/examples/Banner.mdpackages/react-core/src/components/Banner/examples/BannerStatus.tsxpackages/react-core/src/components/Button/examples/Button.mdpackages/react-core/src/components/Button/examples/ButtonCircle.tsxpackages/react-core/src/components/Button/examples/ButtonStateful.tsxpackages/react-core/src/components/Button/examples/ButtonVariations.tsxpackages/react-core/src/components/EmptyState/examples/EmptyState.mdpackages/react-core/src/components/ExpandableSection/__tests__/ExpandableSection.test.tsxpackages/react-core/src/components/ExpandableSection/examples/ExpandableSection.mdpackages/react-core/src/components/ExpandableSection/examples/ExpandableSectionCustomToggle.tsxpackages/react-core/src/components/ExpandableSection/examples/ExpandableSectionWithHeading.tsxpackages/react-core/src/components/FileUpload/examples/FileUpload.mdpackages/react-core/src/components/Form/examples/Form.mdpackages/react-core/src/components/Form/examples/FormInvalid.tsxpackages/react-core/src/components/Form/examples/FormInvalidWithFormAlert.tsxpackages/react-core/src/components/Form/examples/FormState.tsxpackages/react-core/src/components/Form/examples/FormValidated.tsxpackages/react-core/src/components/FormControl/FormControlIcon.tsxpackages/react-core/src/components/HelperText/HelperTextItem.tsxpackages/react-core/src/components/Icon/examples/Icon.mdpackages/react-core/src/components/Icon/examples/IconCustomProgress.tsxpackages/react-core/src/components/Icon/examples/IconProgress.tsxpackages/react-core/src/components/Icon/examples/IconStatus.tsxpackages/react-core/src/components/Label/Label.tsxpackages/react-core/src/components/Label/examples/Label.mdpackages/react-core/src/components/Label/examples/LabelCompact.tsxpackages/react-core/src/components/Label/examples/LabelCustomRender.tsxpackages/react-core/src/components/Label/examples/LabelGroupBasic.tsxpackages/react-core/src/components/Label/examples/LabelGroupCategory.tsxpackages/react-core/src/components/Label/examples/LabelGroupCategoryRemovable.tsxpackages/react-core/src/components/Label/examples/LabelGroupEditableAddModal.tsxpackages/react-core/src/components/Label/examples/LabelGroupOverflow.tsxpackages/react-core/src/components/Label/examples/LabelGroupVerticalCategoryOverflowRemovable.tsxpackages/react-core/src/components/LoginPage/examples/LoginPage.mdpackages/react-core/src/components/LoginPage/examples/LoginPageBasic.tsxpackages/react-core/src/components/LoginPage/examples/LoginPageLanguageSelect.tsxpackages/react-core/src/components/LoginPage/examples/LoginPageShowHidePassword.tsxpackages/react-core/src/components/Menu/examples/Menu.mdpackages/react-core/src/components/Menu/examples/MenuWithActions.tsxpackages/react-core/src/components/Menu/examples/MenuWithFavorites.tsxpackages/react-core/src/components/MenuToggle/MenuToggle.tsxpackages/react-core/src/components/Modal/ModalBoxTitle.tsxpackages/react-core/src/components/MultipleFileUpload/MultipleFileUploadStatus.tsxpackages/react-core/src/components/NotificationBadge/NotificationBadge.tsxpackages/react-core/src/components/NotificationBadge/examples/NotificationBadge.mdpackages/react-core/src/components/NotificationDrawer/NotificationDrawerListItemHeader.tsxpackages/react-core/src/components/NotificationDrawer/__tests__/NotificationDrawerListItemHeader.test.tsxpackages/react-core/src/components/Popover/examples/Popover.mdpackages/react-core/src/components/Popover/examples/PopoverAlert.tsxpackages/react-core/src/components/Progress/ProgressContainer.tsxpackages/react-core/src/components/ProgressStepper/ProgressStep.tsxpackages/react-core/src/components/ProgressStepper/__tests__/ProgressStep.test.tsxpackages/react-core/src/components/Select/examples/Select.mdpackages/react-core/src/components/Select/examples/SelectOptionVariations.tsxpackages/react-core/src/components/Wizard/WizardNavItem.tsxpackages/react-core/src/components/Wizard/WizardToggle.tsxpackages/react-core/src/demos/Button/Button.mdpackages/react-core/src/demos/Button/examples/ButtonProgress.tsxpackages/react-core/src/demos/CardDemos.mdpackages/react-core/src/demos/CustomMenus/CustomMenus.mdpackages/react-core/src/demos/CustomMenus/examples/ActionsMenuDemo.tsxpackages/react-core/src/demos/DataList/examples/DataListBasic.tsxpackages/react-core/src/demos/DataListDemo.mdpackages/react-core/src/demos/DescriptionList/DescriptionList.mdpackages/react-core/src/demos/DescriptionList/examples/DescriptionListBasic.tsxpackages/react-core/src/demos/HelperText.mdpackages/react-core/src/demos/LabelGroupDemos.mdpackages/react-core/src/demos/Masthead.mdpackages/react-core/src/demos/Nav.mdpackages/react-core/src/demos/NotificationDrawer/NotificationDrawer.mdpackages/react-core/src/demos/Page.mdpackages/react-core/src/demos/PasswordStrength.mdpackages/react-core/src/demos/PrimaryDetail.mdpackages/react-core/src/demos/Tabs.mdpackages/react-core/src/demos/examples/Card/CardAggregateStatus.tsxpackages/react-core/src/demos/examples/Card/CardEventsView.tsxpackages/react-core/src/demos/examples/Card/CardHorizontalGrid.tsxpackages/react-core/src/demos/examples/Card/CardStatus.tsxpackages/react-core/src/demos/examples/Card/CardStatusTabbed.tsxpackages/react-core/src/demos/examples/Card/CardUtilizationDemo3.tsxpackages/react-core/src/demos/examples/PasswordStrength/PasswordStrengthDemo.tsxpackages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailContentPadding.tsxpackages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailFullPage.tsxpackages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailInlineModifier.tsxpackages/react-core/src/demos/examples/Tabs/TabsOpen.tsxpackages/react-core/src/demos/examples/Tabs/TabsOpenWithSecondaryTabs.tsxpackages/react-core/src/deprecated/components/Modal/ModalBoxTitle.tsxpackages/react-core/src/deprecated/components/Tile/examples/Tile.mdpackages/react-core/src/deprecated/components/Tile/examples/TileStacked.tsxpackages/react-core/src/deprecated/components/Tile/examples/TileStackedWithLargeIcons.tsxpackages/react-core/src/deprecated/components/Tile/examples/TileWithExtraContent.tsxpackages/react-core/src/helpers/constants.tspackages/react-icons/scripts/icons/pfToRhIcons.mjspackages/react-integration/demo-app-ts/src/components/demos/FormDemo/FormDemo.tsxpackages/react-integration/demo-app-ts/src/components/demos/LabelDemo/LabelDemo.tsxpackages/react-integration/demo-app-ts/src/components/demos/LoginPageDemo/LoginPageDemo.tsxpackages/react-integration/demo-app-ts/src/components/demos/MenuDemo/MenuDemo.tsxpackages/react-table/src/demos/Table.mdpackages/react-table/src/demos/examples/TableEmptyStateError.tsx
💤 Files with no reviewable changes (2)
- packages/react-core/src/components/EmptyState/examples/EmptyState.md
- packages/react-core/src/components/FileUpload/examples/FileUpload.md
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Overall lgtm. I edited this core issue patternfly/patternfly#8127 to mention some additional areas in Core where status icon updates still need to be made thanks to you updating them here.
Only thing is I think the above comments from CodeRabbit should be addressed (also left a reply to the 1st one)
kmcfaul
force-pushed
the
unified-status-icons
branch
from
49e1121 to
68e71da
Compare
There was a problem hiding this comment.
♻️ Duplicate comments (1)
packages/react-core/src/demos/examples/Card/CardStatus.tsx (1)
210-211:⚠️ Potential issue | 🟡 MinorLast two label statuses look semantically swapped.
On Line 210 and Line 211, this likely should be
infothencustom(so the final chip uses the notification icon viaLabel’s internal status mapping).Suggested fix
- <Label status="danger">3</Label> - <Label status="info">3</Label> + <Label status="info">3</Label> + <Label status="custom">3</Label>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/react-core/src/demos/examples/Card/CardStatus.tsx` around lines 210 - 211, The last two Label instances are semantically swapped: instead of status="danger" followed by status="info", change them to status="info" then status="custom" so the final chip renders the notification icon via Label's internal status mapping; update the two Label elements (the two occurrences with status="danger" and status="info") accordingly to status="info" and status="custom".
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@packages/react-core/src/demos/examples/Card/CardStatus.tsx`:
- Around line 210-211: The last two Label instances are semantically swapped:
instead of status="danger" followed by status="info", change them to
status="info" then status="custom" so the final chip renders the notification
icon via Label's internal status mapping; update the two Label elements (the two
occurrences with status="danger" and status="info") accordingly to status="info"
and status="custom".
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b7c71f9d-2e1c-4136-a13d-89b88967bc74
⛔ Files ignored due to path filters (11)
packages/react-core/src/components/Alert/__tests__/Generated/__snapshots__/AlertIcon.test.tsx.snapis excluded by!**/*.snap,!**/generated/**packages/react-core/src/components/FormSelect/__tests__/__snapshots__/FormSelect.test.tsx.snapis excluded by!**/*.snappackages/react-core/src/components/Modal/__tests__/__snapshots__/ModalBoxTitle.test.tsx.snapis excluded by!**/*.snappackages/react-core/src/components/MultipleFileUpload/__tests__/__snapshots__/MultipleFileUploadStatusItem.test.tsx.snapis excluded by!**/*.snappackages/react-core/src/components/NotificationBadge/__tests__/__snapshots__/NotificationBadge.test.tsx.snapis excluded by!**/*.snappackages/react-core/src/components/NotificationDrawer/__tests__/__snapshots__/NotificationDrawerListItemHeader.test.tsx.snapis excluded by!**/*.snappackages/react-core/src/components/NumberInput/__tests__/__snapshots__/NumberInput.test.tsx.snapis excluded by!**/*.snappackages/react-core/src/components/Progress/__tests__/Generated/__snapshots__/ProgressContainer.test.tsx.snapis excluded by!**/*.snap,!**/generated/**packages/react-core/src/components/Progress/__tests__/__snapshots__/Progress.test.tsx.snapis excluded by!**/*.snappackages/react-core/src/components/TextInput/__tests__/__snapshots__/TextInput.test.tsx.snapis excluded by!**/*.snappackages/react-core/src/deprecated/components/Modal/__tests__/__snapshots__/ModalBoxTitle.test.tsx.snapis excluded by!**/*.snap
📒 Files selected for processing (102)
packages/code-connect/components/PopOver/Popover.figma.tsxpackages/react-core/src/components/Alert/AlertIcon.tsxpackages/react-core/src/components/Alert/__tests__/AlertIcon.test.tsxpackages/react-core/src/components/Banner/examples/Banner.mdpackages/react-core/src/components/Banner/examples/BannerStatus.tsxpackages/react-core/src/components/Button/examples/Button.mdpackages/react-core/src/components/Button/examples/ButtonCircle.tsxpackages/react-core/src/components/Button/examples/ButtonStateful.tsxpackages/react-core/src/components/Button/examples/ButtonVariations.tsxpackages/react-core/src/components/EmptyState/examples/EmptyState.mdpackages/react-core/src/components/ExpandableSection/__tests__/ExpandableSection.test.tsxpackages/react-core/src/components/ExpandableSection/examples/ExpandableSection.mdpackages/react-core/src/components/ExpandableSection/examples/ExpandableSectionCustomToggle.tsxpackages/react-core/src/components/ExpandableSection/examples/ExpandableSectionWithHeading.tsxpackages/react-core/src/components/FileUpload/examples/FileUpload.mdpackages/react-core/src/components/Form/examples/Form.mdpackages/react-core/src/components/Form/examples/FormInvalid.tsxpackages/react-core/src/components/Form/examples/FormInvalidWithFormAlert.tsxpackages/react-core/src/components/Form/examples/FormState.tsxpackages/react-core/src/components/Form/examples/FormValidated.tsxpackages/react-core/src/components/FormControl/FormControlIcon.tsxpackages/react-core/src/components/HelperText/HelperTextItem.tsxpackages/react-core/src/components/Icon/examples/Icon.mdpackages/react-core/src/components/Icon/examples/IconCustomProgress.tsxpackages/react-core/src/components/Icon/examples/IconProgress.tsxpackages/react-core/src/components/Icon/examples/IconStatus.tsxpackages/react-core/src/components/Label/Label.tsxpackages/react-core/src/components/Label/examples/Label.mdpackages/react-core/src/components/Label/examples/LabelCompact.tsxpackages/react-core/src/components/Label/examples/LabelCustomRender.tsxpackages/react-core/src/components/Label/examples/LabelGroupBasic.tsxpackages/react-core/src/components/Label/examples/LabelGroupCategory.tsxpackages/react-core/src/components/Label/examples/LabelGroupCategoryRemovable.tsxpackages/react-core/src/components/Label/examples/LabelGroupEditableAddModal.tsxpackages/react-core/src/components/Label/examples/LabelGroupOverflow.tsxpackages/react-core/src/components/Label/examples/LabelGroupVerticalCategoryOverflowRemovable.tsxpackages/react-core/src/components/LoginPage/examples/LoginPage.mdpackages/react-core/src/components/LoginPage/examples/LoginPageBasic.tsxpackages/react-core/src/components/LoginPage/examples/LoginPageLanguageSelect.tsxpackages/react-core/src/components/LoginPage/examples/LoginPageShowHidePassword.tsxpackages/react-core/src/components/Menu/examples/Menu.mdpackages/react-core/src/components/Menu/examples/MenuWithActions.tsxpackages/react-core/src/components/Menu/examples/MenuWithFavorites.tsxpackages/react-core/src/components/MenuToggle/MenuToggle.tsxpackages/react-core/src/components/Modal/ModalBoxTitle.tsxpackages/react-core/src/components/MultipleFileUpload/MultipleFileUploadStatus.tsxpackages/react-core/src/components/NotificationBadge/NotificationBadge.tsxpackages/react-core/src/components/NotificationBadge/examples/NotificationBadge.mdpackages/react-core/src/components/NotificationDrawer/NotificationDrawerListItemHeader.tsxpackages/react-core/src/components/NotificationDrawer/__tests__/NotificationDrawerListItemHeader.test.tsxpackages/react-core/src/components/Popover/examples/Popover.mdpackages/react-core/src/components/Popover/examples/PopoverAlert.tsxpackages/react-core/src/components/Progress/ProgressContainer.tsxpackages/react-core/src/components/ProgressStepper/ProgressStep.tsxpackages/react-core/src/components/ProgressStepper/__tests__/ProgressStep.test.tsxpackages/react-core/src/components/Select/examples/Select.mdpackages/react-core/src/components/Select/examples/SelectOptionVariations.tsxpackages/react-core/src/components/Wizard/WizardNavItem.tsxpackages/react-core/src/components/Wizard/WizardToggle.tsxpackages/react-core/src/demos/Button/Button.mdpackages/react-core/src/demos/Button/examples/ButtonProgress.tsxpackages/react-core/src/demos/CardDemos.mdpackages/react-core/src/demos/CustomMenus/CustomMenus.mdpackages/react-core/src/demos/CustomMenus/examples/ActionsMenuDemo.tsxpackages/react-core/src/demos/DataList/examples/DataListBasic.tsxpackages/react-core/src/demos/DataListDemo.mdpackages/react-core/src/demos/DescriptionList/DescriptionList.mdpackages/react-core/src/demos/DescriptionList/examples/DescriptionListBasic.tsxpackages/react-core/src/demos/HelperText.mdpackages/react-core/src/demos/LabelGroupDemos.mdpackages/react-core/src/demos/Masthead.mdpackages/react-core/src/demos/Nav.mdpackages/react-core/src/demos/NotificationDrawer/NotificationDrawer.mdpackages/react-core/src/demos/Page.mdpackages/react-core/src/demos/PasswordStrength.mdpackages/react-core/src/demos/PrimaryDetail.mdpackages/react-core/src/demos/Tabs.mdpackages/react-core/src/demos/examples/Card/CardAggregateStatus.tsxpackages/react-core/src/demos/examples/Card/CardEventsView.tsxpackages/react-core/src/demos/examples/Card/CardHorizontalGrid.tsxpackages/react-core/src/demos/examples/Card/CardStatus.tsxpackages/react-core/src/demos/examples/Card/CardStatusTabbed.tsxpackages/react-core/src/demos/examples/Card/CardUtilizationDemo3.tsxpackages/react-core/src/demos/examples/PasswordStrength/PasswordStrengthDemo.tsxpackages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailContentPadding.tsxpackages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailFullPage.tsxpackages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailInlineModifier.tsxpackages/react-core/src/demos/examples/Tabs/TabsOpen.tsxpackages/react-core/src/demos/examples/Tabs/TabsOpenWithSecondaryTabs.tsxpackages/react-core/src/deprecated/components/Modal/ModalBoxTitle.tsxpackages/react-core/src/deprecated/components/Tile/examples/Tile.mdpackages/react-core/src/deprecated/components/Tile/examples/TileStacked.tsxpackages/react-core/src/deprecated/components/Tile/examples/TileStackedWithLargeIcons.tsxpackages/react-core/src/deprecated/components/Tile/examples/TileWithExtraContent.tsxpackages/react-core/src/helpers/constants.tspackages/react-icons/scripts/icons/pfToRhIcons.mjspackages/react-integration/demo-app-ts/src/components/demos/FormDemo/FormDemo.tsxpackages/react-integration/demo-app-ts/src/components/demos/LabelDemo/LabelDemo.tsxpackages/react-integration/demo-app-ts/src/components/demos/LoginPageDemo/LoginPageDemo.tsxpackages/react-integration/demo-app-ts/src/components/demos/MenuDemo/MenuDemo.tsxpackages/react-table/src/demos/Table.mdpackages/react-table/src/demos/examples/TableEmptyStateError.tsx
💤 Files with no reviewable changes (2)
- packages/react-core/src/components/EmptyState/examples/EmptyState.md
- packages/react-core/src/components/FileUpload/examples/FileUpload.md
✅ Files skipped from review due to trivial changes (84)
- packages/react-core/src/demos/LabelGroupDemos.md
- packages/react-core/src/demos/CustomMenus/CustomMenus.md
- packages/react-core/src/components/Menu/examples/MenuWithFavorites.tsx
- packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionCustomToggle.tsx
- packages/react-core/src/components/Label/examples/LabelCustomRender.tsx
- packages/react-core/src/demos/examples/Card/CardUtilizationDemo3.tsx
- packages/react-core/src/demos/examples/Card/CardHorizontalGrid.tsx
- packages/react-core/src/components/Select/examples/SelectOptionVariations.tsx
- packages/react-core/src/demos/DescriptionList/examples/DescriptionListBasic.tsx
- packages/react-core/src/components/Button/examples/ButtonVariations.tsx
- packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionWithHeading.tsx
- packages/react-core/src/components/Icon/examples/IconProgress.tsx
- packages/react-core/src/components/Form/examples/FormInvalid.tsx
- packages/react-core/src/components/LoginPage/examples/LoginPageBasic.tsx
- packages/react-core/src/demos/NotificationDrawer/NotificationDrawer.md
- packages/react-core/src/demos/examples/Card/CardStatusTabbed.tsx
- packages/react-core/src/demos/Button/Button.md
- packages/react-core/src/components/Form/examples/FormState.tsx
- packages/react-core/src/demos/Button/examples/ButtonProgress.tsx
- packages/react-core/src/demos/PasswordStrength.md
- packages/react-core/src/components/Form/examples/FormValidated.tsx
- packages/react-core/src/demos/examples/Card/CardEventsView.tsx
- packages/react-core/src/demos/CustomMenus/examples/ActionsMenuDemo.tsx
- packages/react-core/src/components/Label/examples/LabelGroupOverflow.tsx
- packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailContentPadding.tsx
- packages/react-core/src/components/Popover/examples/Popover.md
- packages/react-core/src/components/NotificationDrawer/tests/NotificationDrawerListItemHeader.test.tsx
- packages/react-core/src/components/NotificationBadge/examples/NotificationBadge.md
- packages/react-core/src/components/Form/examples/FormInvalidWithFormAlert.tsx
- packages/react-integration/demo-app-ts/src/components/demos/LoginPageDemo/LoginPageDemo.tsx
- packages/react-core/src/components/Wizard/WizardToggle.tsx
- packages/react-core/src/components/LoginPage/examples/LoginPageShowHidePassword.tsx
- packages/react-core/src/components/Label/examples/LabelGroupCategoryRemovable.tsx
- packages/react-core/src/components/Label/examples/Label.md
- packages/react-core/src/demos/HelperText.md
- packages/react-integration/demo-app-ts/src/components/demos/FormDemo/FormDemo.tsx
- packages/react-core/src/components/Button/examples/ButtonStateful.tsx
- packages/react-core/src/components/Progress/ProgressContainer.tsx
- packages/react-core/src/demos/Nav.md
- packages/react-core/src/demos/examples/Tabs/TabsOpenWithSecondaryTabs.tsx
- packages/react-core/src/components/ExpandableSection/examples/ExpandableSection.md
- packages/react-core/src/components/Modal/ModalBoxTitle.tsx
- packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailFullPage.tsx
- packages/react-core/src/components/Banner/examples/Banner.md
- packages/react-core/src/components/Menu/examples/Menu.md
- packages/react-core/src/demos/Tabs.md
- packages/react-core/src/components/Label/examples/LabelGroupCategory.tsx
- packages/react-core/src/components/Button/examples/Button.md
- packages/react-core/src/components/Popover/examples/PopoverAlert.tsx
- packages/react-core/src/components/Form/examples/Form.md
- packages/react-core/src/components/Button/examples/ButtonCircle.tsx
- packages/react-core/src/deprecated/components/Tile/examples/Tile.md
- packages/react-core/src/demos/CardDemos.md
- packages/react-core/src/components/Label/examples/LabelGroupEditableAddModal.tsx
- packages/react-core/src/components/Select/examples/Select.md
- packages/react-core/src/components/Wizard/WizardNavItem.tsx
- packages/react-core/src/components/LoginPage/examples/LoginPage.md
- packages/react-core/src/deprecated/components/Tile/examples/TileStacked.tsx
- packages/react-core/src/components/Label/examples/LabelGroupBasic.tsx
- packages/react-core/src/components/NotificationBadge/NotificationBadge.tsx
- packages/react-core/src/components/ExpandableSection/tests/ExpandableSection.test.tsx
- packages/react-core/src/components/ProgressStepper/ProgressStep.tsx
- packages/react-core/src/deprecated/components/Tile/examples/TileStackedWithLargeIcons.tsx
- packages/react-core/src/deprecated/components/Tile/examples/TileWithExtraContent.tsx
- packages/react-table/src/demos/examples/TableEmptyStateError.tsx
- packages/react-core/src/components/Icon/examples/IconStatus.tsx
- packages/react-core/src/components/Label/examples/LabelGroupVerticalCategoryOverflowRemovable.tsx
- packages/react-core/src/components/Alert/tests/AlertIcon.test.tsx
- packages/react-core/src/demos/examples/PasswordStrength/PasswordStrengthDemo.tsx
- packages/react-core/src/demos/Masthead.md
- packages/react-table/src/demos/Table.md
- packages/react-core/src/components/Banner/examples/BannerStatus.tsx
- packages/react-core/src/demos/examples/Card/CardAggregateStatus.tsx
- packages/react-core/src/components/Alert/AlertIcon.tsx
- packages/react-core/src/components/Icon/examples/IconCustomProgress.tsx
- packages/code-connect/components/PopOver/Popover.figma.tsx
- packages/react-integration/demo-app-ts/src/components/demos/MenuDemo/MenuDemo.tsx
- packages/react-core/src/components/Menu/examples/MenuWithActions.tsx
- packages/react-core/src/demos/Page.md
- packages/react-integration/demo-app-ts/src/components/demos/LabelDemo/LabelDemo.tsx
- packages/react-core/src/components/HelperText/HelperTextItem.tsx
- packages/react-core/src/demos/DataList/examples/DataListBasic.tsx
- packages/react-core/src/demos/DataListDemo.md
- packages/react-core/src/components/Icon/examples/Icon.md
🚧 Files skipped from review as they are similar to previous changes (13)
- packages/react-core/src/demos/DescriptionList/DescriptionList.md
- packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailInlineModifier.tsx
- packages/react-core/src/demos/PrimaryDetail.md
- packages/react-core/src/components/LoginPage/examples/LoginPageLanguageSelect.tsx
- packages/react-core/src/components/Label/examples/LabelCompact.tsx
- packages/react-core/src/demos/examples/Tabs/TabsOpen.tsx
- packages/react-core/src/components/MenuToggle/MenuToggle.tsx
- packages/react-core/src/components/Label/Label.tsx
- packages/react-core/src/components/FormControl/FormControlIcon.tsx
- packages/react-core/src/helpers/constants.ts
- packages/react-core/src/components/ProgressStepper/tests/ProgressStep.test.tsx
- packages/react-core/src/components/NotificationDrawer/NotificationDrawerListItemHeader.tsx
- packages/react-icons/scripts/icons/pfToRhIcons.mjs
thatblindgeye
approved these changes
Mar 31, 2026
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
If coderabbit can suggest changes on our behalf then I can approve on its behalf
kmcfaul
force-pushed
the
unified-status-icons
branch
from
68e71da to
ea90d2f
Compare
There was a problem hiding this comment.
♻️ Duplicate comments (1)
packages/react-core/src/demos/examples/Card/CardStatus.tsx (1)
210-211:⚠️ Potential issue | 🟡 MinorFix status mapping for the last two notification labels.
Line 210 should be
info(notdanger), and Line 211 should becustom(notification), otherwise the semantic/icon mapping is off.Suggested fix
- <Label status="danger">3</Label> - <Label status="info">3</Label> + <Label status="info">3</Label> + <Label status="custom">3</Label>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/react-core/src/demos/examples/Card/CardStatus.tsx` around lines 210 - 211, The last two Label components in CardStatus.tsx currently use incorrect status values; update the Label with text "3" at the first of those two occurrences to use status="info" instead of "danger", and update the subsequent Label with text "3" to use status="custom" (notification) instead of "info" so the semantic/icon mapping aligns correctly—look for the Label components in the CardStatus demo and adjust their status props accordingly.
🧹 Nitpick comments (1)
packages/react-core/src/components/Progress/ProgressContainer.tsx (1)
65-69: Consider reusing the sharedstatusIconsmapping to avoid drift.This local map duplicates
packages/react-core/src/helpers/constants.tsand may diverge later.♻️ Suggested refactor
+import { statusIcons } from '../../helpers/constants'; + -const variantToIcon = { - danger: RhUiErrorFillIcon, - success: RhUiCheckCircleFillIcon, - warning: RhUiWarningFillIcon -}; +const variantToIcon = { + danger: statusIcons.danger, + success: statusIcons.success, + warning: statusIcons.warning +};🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/react-core/src/components/Progress/ProgressContainer.tsx` around lines 65 - 69, The local mapping variantToIcon duplicates the shared statusIcons constant and risks drifting; replace the local object with an import of statusIcons from packages/react-core/src/helpers/constants (or the module that exports it) and use statusIcons where variantToIcon is referenced (ensure names like variantToIcon usages, RhUiErrorFillIcon/RhUiCheckCircleFillIcon/RhUiWarningFillIcon references remain valid); remove the redundant variantToIcon declaration so the component relies on the single source-of-truth statusIcons mapping.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@packages/react-core/src/demos/examples/Card/CardStatus.tsx`:
- Around line 210-211: The last two Label components in CardStatus.tsx currently
use incorrect status values; update the Label with text "3" at the first of
those two occurrences to use status="info" instead of "danger", and update the
subsequent Label with text "3" to use status="custom" (notification) instead of
"info" so the semantic/icon mapping aligns correctly—look for the Label
components in the CardStatus demo and adjust their status props accordingly.
---
Nitpick comments:
In `@packages/react-core/src/components/Progress/ProgressContainer.tsx`:
- Around line 65-69: The local mapping variantToIcon duplicates the shared
statusIcons constant and risks drifting; replace the local object with an import
of statusIcons from packages/react-core/src/helpers/constants (or the module
that exports it) and use statusIcons where variantToIcon is referenced (ensure
names like variantToIcon usages,
RhUiErrorFillIcon/RhUiCheckCircleFillIcon/RhUiWarningFillIcon references remain
valid); remove the redundant variantToIcon declaration so the component relies
on the single source-of-truth statusIcons mapping.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 97ee7661-97c3-4c97-af50-569cd9f7b27f
⛔ Files ignored due to path filters (11)
packages/react-core/src/components/Alert/__tests__/Generated/__snapshots__/AlertIcon.test.tsx.snapis excluded by!**/*.snap,!**/generated/**packages/react-core/src/components/FormSelect/__tests__/__snapshots__/FormSelect.test.tsx.snapis excluded by!**/*.snappackages/react-core/src/components/Modal/__tests__/__snapshots__/ModalBoxTitle.test.tsx.snapis excluded by!**/*.snappackages/react-core/src/components/MultipleFileUpload/__tests__/__snapshots__/MultipleFileUploadStatusItem.test.tsx.snapis excluded by!**/*.snappackages/react-core/src/components/NotificationBadge/__tests__/__snapshots__/NotificationBadge.test.tsx.snapis excluded by!**/*.snappackages/react-core/src/components/NotificationDrawer/__tests__/__snapshots__/NotificationDrawerListItemHeader.test.tsx.snapis excluded by!**/*.snappackages/react-core/src/components/NumberInput/__tests__/__snapshots__/NumberInput.test.tsx.snapis excluded by!**/*.snappackages/react-core/src/components/Progress/__tests__/Generated/__snapshots__/ProgressContainer.test.tsx.snapis excluded by!**/*.snap,!**/generated/**packages/react-core/src/components/Progress/__tests__/__snapshots__/Progress.test.tsx.snapis excluded by!**/*.snappackages/react-core/src/components/TextInput/__tests__/__snapshots__/TextInput.test.tsx.snapis excluded by!**/*.snappackages/react-core/src/deprecated/components/Modal/__tests__/__snapshots__/ModalBoxTitle.test.tsx.snapis excluded by!**/*.snap
📒 Files selected for processing (102)
packages/code-connect/components/PopOver/Popover.figma.tsxpackages/react-core/src/components/Alert/AlertIcon.tsxpackages/react-core/src/components/Alert/__tests__/AlertIcon.test.tsxpackages/react-core/src/components/Banner/examples/Banner.mdpackages/react-core/src/components/Banner/examples/BannerStatus.tsxpackages/react-core/src/components/Button/examples/Button.mdpackages/react-core/src/components/Button/examples/ButtonCircle.tsxpackages/react-core/src/components/Button/examples/ButtonStateful.tsxpackages/react-core/src/components/Button/examples/ButtonVariations.tsxpackages/react-core/src/components/EmptyState/examples/EmptyState.mdpackages/react-core/src/components/ExpandableSection/__tests__/ExpandableSection.test.tsxpackages/react-core/src/components/ExpandableSection/examples/ExpandableSection.mdpackages/react-core/src/components/ExpandableSection/examples/ExpandableSectionCustomToggle.tsxpackages/react-core/src/components/ExpandableSection/examples/ExpandableSectionWithHeading.tsxpackages/react-core/src/components/FileUpload/examples/FileUpload.mdpackages/react-core/src/components/Form/examples/Form.mdpackages/react-core/src/components/Form/examples/FormInvalid.tsxpackages/react-core/src/components/Form/examples/FormInvalidWithFormAlert.tsxpackages/react-core/src/components/Form/examples/FormState.tsxpackages/react-core/src/components/Form/examples/FormValidated.tsxpackages/react-core/src/components/FormControl/FormControlIcon.tsxpackages/react-core/src/components/HelperText/HelperTextItem.tsxpackages/react-core/src/components/Icon/examples/Icon.mdpackages/react-core/src/components/Icon/examples/IconCustomProgress.tsxpackages/react-core/src/components/Icon/examples/IconProgress.tsxpackages/react-core/src/components/Icon/examples/IconStatus.tsxpackages/react-core/src/components/Label/Label.tsxpackages/react-core/src/components/Label/examples/Label.mdpackages/react-core/src/components/Label/examples/LabelCompact.tsxpackages/react-core/src/components/Label/examples/LabelCustomRender.tsxpackages/react-core/src/components/Label/examples/LabelGroupBasic.tsxpackages/react-core/src/components/Label/examples/LabelGroupCategory.tsxpackages/react-core/src/components/Label/examples/LabelGroupCategoryRemovable.tsxpackages/react-core/src/components/Label/examples/LabelGroupEditableAddModal.tsxpackages/react-core/src/components/Label/examples/LabelGroupOverflow.tsxpackages/react-core/src/components/Label/examples/LabelGroupVerticalCategoryOverflowRemovable.tsxpackages/react-core/src/components/LoginPage/examples/LoginPage.mdpackages/react-core/src/components/LoginPage/examples/LoginPageBasic.tsxpackages/react-core/src/components/LoginPage/examples/LoginPageLanguageSelect.tsxpackages/react-core/src/components/LoginPage/examples/LoginPageShowHidePassword.tsxpackages/react-core/src/components/Menu/examples/Menu.mdpackages/react-core/src/components/Menu/examples/MenuWithActions.tsxpackages/react-core/src/components/Menu/examples/MenuWithFavorites.tsxpackages/react-core/src/components/MenuToggle/MenuToggle.tsxpackages/react-core/src/components/Modal/ModalBoxTitle.tsxpackages/react-core/src/components/MultipleFileUpload/MultipleFileUploadStatus.tsxpackages/react-core/src/components/NotificationBadge/NotificationBadge.tsxpackages/react-core/src/components/NotificationBadge/examples/NotificationBadge.mdpackages/react-core/src/components/NotificationDrawer/NotificationDrawerListItemHeader.tsxpackages/react-core/src/components/NotificationDrawer/__tests__/NotificationDrawerListItemHeader.test.tsxpackages/react-core/src/components/Popover/examples/Popover.mdpackages/react-core/src/components/Popover/examples/PopoverAlert.tsxpackages/react-core/src/components/Progress/ProgressContainer.tsxpackages/react-core/src/components/ProgressStepper/ProgressStep.tsxpackages/react-core/src/components/ProgressStepper/__tests__/ProgressStep.test.tsxpackages/react-core/src/components/Select/examples/Select.mdpackages/react-core/src/components/Select/examples/SelectOptionVariations.tsxpackages/react-core/src/components/Wizard/WizardNavItem.tsxpackages/react-core/src/components/Wizard/WizardToggle.tsxpackages/react-core/src/demos/Button/Button.mdpackages/react-core/src/demos/Button/examples/ButtonProgress.tsxpackages/react-core/src/demos/CardDemos.mdpackages/react-core/src/demos/CustomMenus/CustomMenus.mdpackages/react-core/src/demos/CustomMenus/examples/ActionsMenuDemo.tsxpackages/react-core/src/demos/DataList/examples/DataListBasic.tsxpackages/react-core/src/demos/DataListDemo.mdpackages/react-core/src/demos/DescriptionList/DescriptionList.mdpackages/react-core/src/demos/DescriptionList/examples/DescriptionListBasic.tsxpackages/react-core/src/demos/HelperText.mdpackages/react-core/src/demos/LabelGroupDemos.mdpackages/react-core/src/demos/Masthead.mdpackages/react-core/src/demos/Nav.mdpackages/react-core/src/demos/NotificationDrawer/NotificationDrawer.mdpackages/react-core/src/demos/Page.mdpackages/react-core/src/demos/PasswordStrength.mdpackages/react-core/src/demos/PrimaryDetail.mdpackages/react-core/src/demos/Tabs.mdpackages/react-core/src/demos/examples/Card/CardAggregateStatus.tsxpackages/react-core/src/demos/examples/Card/CardEventsView.tsxpackages/react-core/src/demos/examples/Card/CardHorizontalGrid.tsxpackages/react-core/src/demos/examples/Card/CardStatus.tsxpackages/react-core/src/demos/examples/Card/CardStatusTabbed.tsxpackages/react-core/src/demos/examples/Card/CardUtilizationDemo3.tsxpackages/react-core/src/demos/examples/PasswordStrength/PasswordStrengthDemo.tsxpackages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailContentPadding.tsxpackages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailFullPage.tsxpackages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailInlineModifier.tsxpackages/react-core/src/demos/examples/Tabs/TabsOpen.tsxpackages/react-core/src/demos/examples/Tabs/TabsOpenWithSecondaryTabs.tsxpackages/react-core/src/deprecated/components/Modal/ModalBoxTitle.tsxpackages/react-core/src/deprecated/components/Tile/examples/Tile.mdpackages/react-core/src/deprecated/components/Tile/examples/TileStacked.tsxpackages/react-core/src/deprecated/components/Tile/examples/TileStackedWithLargeIcons.tsxpackages/react-core/src/deprecated/components/Tile/examples/TileWithExtraContent.tsxpackages/react-core/src/helpers/constants.tspackages/react-icons/scripts/icons/pfToRhIcons.mjspackages/react-integration/demo-app-ts/src/components/demos/FormDemo/FormDemo.tsxpackages/react-integration/demo-app-ts/src/components/demos/LabelDemo/LabelDemo.tsxpackages/react-integration/demo-app-ts/src/components/demos/LoginPageDemo/LoginPageDemo.tsxpackages/react-integration/demo-app-ts/src/components/demos/MenuDemo/MenuDemo.tsxpackages/react-table/src/demos/Table.mdpackages/react-table/src/demos/examples/TableEmptyStateError.tsx
💤 Files with no reviewable changes (2)
- packages/react-core/src/components/EmptyState/examples/EmptyState.md
- packages/react-core/src/components/FileUpload/examples/FileUpload.md
✅ Files skipped from review due to trivial changes (92)
- packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionCustomToggle.tsx
- packages/react-core/src/components/Button/examples/ButtonVariations.tsx
- packages/react-core/src/components/Form/examples/FormValidated.tsx
- packages/react-core/src/components/Button/examples/Button.md
- packages/react-core/src/components/LoginPage/examples/LoginPageLanguageSelect.tsx
- packages/react-core/src/demos/DataListDemo.md
- packages/react-core/src/components/LoginPage/examples/LoginPageBasic.tsx
- packages/react-core/src/components/Label/examples/LabelGroupEditableAddModal.tsx
- packages/react-core/src/components/Button/examples/ButtonStateful.tsx
- packages/react-core/src/components/Banner/examples/Banner.md
- packages/react-core/src/demos/CardDemos.md
- packages/react-core/src/components/ExpandableSection/tests/ExpandableSection.test.tsx
- packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionWithHeading.tsx
- packages/code-connect/components/PopOver/Popover.figma.tsx
- packages/react-core/src/components/NotificationBadge/examples/NotificationBadge.md
- packages/react-core/src/components/Form/examples/Form.md
- packages/react-core/src/components/Form/examples/FormInvalidWithFormAlert.tsx
- packages/react-core/src/components/MultipleFileUpload/MultipleFileUploadStatus.tsx
- packages/react-core/src/demos/DescriptionList/DescriptionList.md
- packages/react-core/src/components/NotificationDrawer/tests/NotificationDrawerListItemHeader.test.tsx
- packages/react-core/src/components/Menu/examples/MenuWithFavorites.tsx
- packages/react-core/src/components/Banner/examples/BannerStatus.tsx
- packages/react-core/src/components/Form/examples/FormInvalid.tsx
- packages/react-core/src/demos/Page.md
- packages/react-core/src/components/ExpandableSection/examples/ExpandableSection.md
- packages/react-core/src/components/Icon/examples/Icon.md
- packages/react-core/src/demos/LabelGroupDemos.md
- packages/react-core/src/components/Menu/examples/Menu.md
- packages/react-core/src/components/Form/examples/FormState.tsx
- packages/react-core/src/components/Wizard/WizardToggle.tsx
- packages/react-core/src/components/Label/examples/LabelGroupCategoryRemovable.tsx
- packages/react-core/src/components/Label/examples/LabelGroupCategory.tsx
- packages/react-core/src/components/Alert/tests/AlertIcon.test.tsx
- packages/react-core/src/components/Label/examples/LabelGroupBasic.tsx
- packages/react-core/src/components/Label/examples/LabelCompact.tsx
- packages/react-core/src/components/Popover/examples/Popover.md
- packages/react-core/src/demos/Nav.md
- packages/react-core/src/components/Alert/AlertIcon.tsx
- packages/react-core/src/components/Icon/examples/IconProgress.tsx
- packages/react-core/src/demos/examples/Card/CardUtilizationDemo3.tsx
- packages/react-integration/demo-app-ts/src/components/demos/LoginPageDemo/LoginPageDemo.tsx
- packages/react-core/src/deprecated/components/Tile/examples/Tile.md
- packages/react-core/src/components/Label/examples/Label.md
- packages/react-core/src/demos/NotificationDrawer/NotificationDrawer.md
- packages/react-core/src/components/LoginPage/examples/LoginPageShowHidePassword.tsx
- packages/react-core/src/deprecated/components/Tile/examples/TileWithExtraContent.tsx
- packages/react-core/src/components/MenuToggle/MenuToggle.tsx
- packages/react-table/src/demos/Table.md
- packages/react-core/src/demos/DescriptionList/examples/DescriptionListBasic.tsx
- packages/react-core/src/components/Menu/examples/MenuWithActions.tsx
- packages/react-core/src/components/Label/Label.tsx
- packages/react-core/src/components/Select/examples/SelectOptionVariations.tsx
- packages/react-core/src/demos/CustomMenus/examples/ActionsMenuDemo.tsx
- packages/react-core/src/components/Icon/examples/IconStatus.tsx
- packages/react-core/src/demos/PasswordStrength.md
- packages/react-core/src/demos/Masthead.md
- packages/react-core/src/demos/Tabs.md
- packages/react-core/src/components/LoginPage/examples/LoginPage.md
- packages/react-core/src/components/Label/examples/LabelGroupVerticalCategoryOverflowRemovable.tsx
- packages/react-core/src/demos/examples/Card/CardStatusTabbed.tsx
- packages/react-core/src/demos/examples/Tabs/TabsOpenWithSecondaryTabs.tsx
- packages/react-integration/demo-app-ts/src/components/demos/FormDemo/FormDemo.tsx
- packages/react-core/src/components/Popover/examples/PopoverAlert.tsx
- packages/react-core/src/components/Wizard/WizardNavItem.tsx
- packages/react-core/src/demos/DataList/examples/DataListBasic.tsx
- packages/react-core/src/demos/HelperText.md
- packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailContentPadding.tsx
- packages/react-core/src/demos/Button/Button.md
- packages/react-core/src/components/HelperText/HelperTextItem.tsx
- packages/react-core/src/components/Select/examples/Select.md
- packages/react-core/src/demos/examples/Card/CardHorizontalGrid.tsx
- packages/react-core/src/components/Icon/examples/IconCustomProgress.tsx
- packages/react-core/src/components/Label/examples/LabelGroupOverflow.tsx
- packages/react-core/src/deprecated/components/Tile/examples/TileStackedWithLargeIcons.tsx
- packages/react-core/src/demos/examples/Tabs/TabsOpen.tsx
- packages/react-core/src/deprecated/components/Tile/examples/TileStacked.tsx
- packages/react-table/src/demos/examples/TableEmptyStateError.tsx
- packages/react-core/src/components/ProgressStepper/ProgressStep.tsx
- packages/react-core/src/demos/examples/Card/CardEventsView.tsx
- packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailFullPage.tsx
- packages/react-integration/demo-app-ts/src/components/demos/LabelDemo/LabelDemo.tsx
- packages/react-core/src/components/NotificationBadge/NotificationBadge.tsx
- packages/react-core/src/demos/examples/Card/CardAggregateStatus.tsx
- packages/react-core/src/components/Modal/ModalBoxTitle.tsx
- packages/react-core/src/components/FormControl/FormControlIcon.tsx
- packages/react-core/src/deprecated/components/Modal/ModalBoxTitle.tsx
- packages/react-core/src/demos/CustomMenus/CustomMenus.md
- packages/react-core/src/demos/PrimaryDetail.md
- packages/react-core/src/components/Label/examples/LabelCustomRender.tsx
- packages/react-core/src/demos/Button/examples/ButtonProgress.tsx
- packages/react-core/src/demos/examples/PasswordStrength/PasswordStrengthDemo.tsx
- packages/react-core/src/helpers/constants.ts
🚧 Files skipped from review as they are similar to previous changes (6)
- packages/react-core/src/components/Button/examples/ButtonCircle.tsx
- packages/react-integration/demo-app-ts/src/components/demos/MenuDemo/MenuDemo.tsx
- packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailInlineModifier.tsx
- packages/react-core/src/components/ProgressStepper/tests/ProgressStep.test.tsx
- packages/react-core/src/components/NotificationDrawer/NotificationDrawerListItemHeader.tsx
- packages/react-icons/scripts/icons/pfToRhIcons.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #12260
Updated the following icons:
CheckCircleIcontoRhUiCheckCircleFillIconExclamationTriangleIcontoRhUiWarningFillIconExclamationCircleIcontoRhUiErrorFillIconInfoCircleIcontoRhUiInformationFillIconBellIcontoRhUiNotificationFillIconAlso went and updated
AttentionBellIcontoRhUiAttentionBellFillIconinNotificationBadgesince that was similar to the new bell icon.Finally, also updated the
pfToRhIconsmapping in react-icons to use the fill versions for consistency.Summary by CodeRabbit