fix(button): define missing variables and remove unused ones#8136
Open
tarunvashishth wants to merge 1 commit intopatternfly:mainfrom
Open
fix(button): define missing variables and remove unused ones#8136tarunvashishth wants to merge 1 commit intopatternfly:mainfrom
tarunvashishth wants to merge 1 commit intopatternfly:mainfrom
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 WalkthroughThis PR fixes undefined and unused variables in the Button component SCSS by defining missing font size and weight properties for the large display variant, introducing corner-specific border radius variables, wiring transition delay for hover icon animations, utilizing the previously unused disabled border color variable, and removing unused progress opacity definitions. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
|
Preview: https://pf-pr-8136.surge.sh A11y report: https://pf-pr-8136-a11y.surge.sh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7952
PR Summary
This PR fixes undefined/unused Button CSS variable issues in
src/patternfly/components/Button/button.scss.display-lgtoken:--#{$button}--m-display-lg--FontSize.--#{$button}--m-display-lg--FontWeightinto.pf-m-display-lg.--#{$button}--disabled--BorderColor.BorderStartStart/StartEnd/EndStart/EndEndRadius) to match existingvar(...)usage.--#{$button}__progress--Opacity.Summary by CodeRabbit
New Features
Style