Change the MavenPomCache init logic - #1164

Merged

greg-at-moderne merged 1 commit into

mainfrom

greg-fix-basicit-snapshot-flaky

Jun 9, 2026

greg-at-moderne commented Jun 9, 2026

Contributor

What's changed?

Changing the MavenPomCache initialization logic.
Mostly about not creating two InMemoryMavenPomCache twice (in the error handling).
Then followed by a refactor.

What's your motivation?

Reacting to a flakiness in tests: https://github.com/openrewrite/rewrite-maven-plugin/actions/runs/27161624615/attempts/1

[ERROR] Tests run: 5, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 33.16 s <<< FAILURE! -- in org.openrewrite.maven.BasicIT
[ERROR] org.openrewrite.maven.BasicIT.snapshot_ok(MavenExecutionResult) -- Time elapsed: 32.64 s <<< FAILURE!
java.lang.AssertionError: 

Expecting empty but was: ["Unable to initialize RocksdbMavenPomCache, falling back to InMemoryMavenPomCache",
    "This Gauge has been already registered (MeterId{name='cache.size', tags=[tag(cache=Maven POMs - default)]}), the registration will be ignored. Note that subsequent logs will be logged at debug level."]
	at org.openrewrite.maven.BasicIT.snapshot_ok(BasicIT.java:95)


          Change the MavenPomCache init logic

587f297

moderne-meeseeks Bot added this to OpenRewrite

moderne-meeseeks Bot assigned greg-at-moderne

github-project-automation Bot moved this to In Progress in OpenRewrite

greg-at-moderne merged commit 962cc40 into main

1 check passed

greg-at-moderne deleted the greg-fix-basicit-snapshot-flaky branch

June 9, 2026 07:22

github-project-automation Bot moved this from In Progress to Done in OpenRewrite

mergify Bot added a commit to robfrank/linklift that referenced this pull request


          chore(deps-dev): bump org.openrewrite.maven:rewrite-maven-plugin from…

c45cb2c

… 6.41.0 to 6.42.0 [skip ci]

Bumps [org.openrewrite.maven:rewrite-maven-plugin](https://github.com/openrewrite/rewrite-maven-plugin) from 6.41.0 to 6.42.0.
Release notes

*Sourced from [org.openrewrite.maven:rewrite-maven-plugin's releases](https://github.com/openrewrite/rewrite-maven-plugin/releases).*

> 6.42.0
> ------
>
> What's Changed
> --------------
>
> * chore(ci): bump rtCamp/action-slack-notify from 2.3.3 to 2.4.0 by [`@dependabot`](https://github.com/dependabot)[bot] in [openrewrite/rewrite-maven-plugin#1162](https://redirect.github.com/openrewrite/rewrite-maven-plugin/pull/1162)
> * chore(ci): bump org.openrewrite:rewrite-bom from 8.84.0 to 8.84.4 by [`@dependabot`](https://github.com/dependabot)[bot] in [openrewrite/rewrite-maven-plugin#1163](https://redirect.github.com/openrewrite/rewrite-maven-plugin/pull/1163)
> * Change the MavenPomCache init logic by [`@greg-at-moderne`](https://github.com/greg-at-moderne) in [openrewrite/rewrite-maven-plugin#1164](https://redirect.github.com/openrewrite/rewrite-maven-plugin/pull/1164)
> * Remove .context files by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-maven-plugin#1165](https://redirect.github.com/openrewrite/rewrite-maven-plugin/pull/1165)
> * Switch to packages.nuxeo.com in BasicIT by [`@greg-at-moderne`](https://github.com/greg-at-moderne) in [openrewrite/rewrite-maven-plugin#1167](https://redirect.github.com/openrewrite/rewrite-maven-plugin/pull/1167)
> * chore(ci): bump io.micrometer:micrometer-core from 1.16.5 to 1.17.0 by [`@dependabot`](https://github.com/dependabot)[bot] in [openrewrite/rewrite-maven-plugin#1166](https://redirect.github.com/openrewrite/rewrite-maven-plugin/pull/1166)
> * Apply configured styles after auto-detected styles; tighten parser visibility by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-maven-plugin#1116](https://redirect.github.com/openrewrite/rewrite-maven-plugin/pull/1116)
>
> **Full Changelog**: <openrewrite/rewrite-maven-plugin@v6.41.0...v6.42.0>


Commits

* [`64b0e5f`](openrewrite/rewrite-maven-plugin@64b0e5f) [maven-release-plugin] prepare release v6.42.0
* [`d360daa`](openrewrite/rewrite-maven-plugin@d360daa) Bump rewrite.version property
* [`dbe81d4`](openrewrite/rewrite-maven-plugin@dbe81d4) Apply configured styles after auto-detected styles; tighten parser visibility...
* [`c4cc317`](openrewrite/rewrite-maven-plugin@c4cc317) chore(ci): bump io.micrometer:micrometer-core from 1.16.5 to 1.17.0 ([#1166](https://redirect.github.com/openrewrite/rewrite-maven-plugin/issues/1166))
* [`af2ae2f`](openrewrite/rewrite-maven-plugin@af2ae2f) Switch to packages.nuxeo.com ([#1167](https://redirect.github.com/openrewrite/rewrite-maven-plugin/issues/1167))
* [`1f337f0`](openrewrite/rewrite-maven-plugin@1f337f0) Bump rewrite.version property
* [`c6d8097`](openrewrite/rewrite-maven-plugin@c6d8097) git-ignore .context/
* [`cfd5b08`](openrewrite/rewrite-maven-plugin@cfd5b08) Remove .context files ([#1165](https://redirect.github.com/openrewrite/rewrite-maven-plugin/issues/1165))
* [`962cc40`](openrewrite/rewrite-maven-plugin@962cc40) Change the MavenPomCache init logic ([#1164](https://redirect.github.com/openrewrite/rewrite-maven-plugin/issues/1164))
* [`45c5bd6`](openrewrite/rewrite-maven-plugin@45c5bd6) chore(ci): bump org.openrewrite:rewrite-bom from 8.84.0 to 8.84.4 ([#1163](https://redirect.github.com/openrewrite/rewrite-maven-plugin/issues/1163))
* Additional commits viewable in [compare view](openrewrite/rewrite-maven-plugin@v6.41.0...v6.42.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet