Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the aws-lc dependency version from v1.68.0 to v1.71.0 in the README and Dockerfile. A review comment identifies a missing update to the AWSLC_VERSION variable in the CI configuration, which is necessary to maintain consistency between the build environment and automated tests.
| ca-certificates media-types | ||
|
|
||
| git clone --depth 1 -b v1.68.0 https://github.com/aws/aws-lc | ||
| git clone --depth 1 -b v1.71.0 https://github.com/aws/aws-lc |
There was a problem hiding this comment.
There appears to be a missing change. The CI script ci/build_aws-lc.sh uses a variable ${AWSLC_VERSION} to specify the aws-lc version. This PR updates the version in README.rst and docker/Dockerfile, but the CI configuration that defines ${AWSLC_VERSION} seems to be untouched. This will lead to a discrepancy where CI tests a different version of aws-lc than what is specified in the build files. To ensure consistency, the ${AWSLC_VERSION} variable in the CI configuration should also be updated to v1.71.0.
1 participant
No description provided.