Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the wolfSSL version from v5.8.4-stable to v5.9.0-stable in the README and the interop Dockerfile. Feedback suggests improving maintainability and consistency by defining the version as a variable or build argument rather than hardcoding it in multiple locations.
| .. code-block:: shell | ||
|
|
||
| $ git clone --depth 1 -b v5.8.4-stable https://github.com/wolfSSL/wolfssl | ||
| $ git clone --depth 1 -b v5.9.0-stable https://github.com/wolfSSL/wolfssl |
There was a problem hiding this comment.
For consistency with other build examples in this file (e.g., for libressl on line 174), consider defining the version in a variable. This makes it clearer which version is being used and easier to update.
| $ git clone --depth 1 -b v5.9.0-stable https://github.com/wolfSSL/wolfssl | |
| $ WOLFSSL_VERSION=v5.9.0-stable | |
| $ git clone --depth 1 -b $WOLFSSL_VERSION https://github.com/wolfSSL/wolfssl |
| esac | ||
|
|
||
| git clone --depth 1 -b v5.8.4-stable https://github.com/wolfSSL/wolfssl | ||
| git clone --depth 1 -b v5.9.0-stable https://github.com/wolfSSL/wolfssl |
There was a problem hiding this comment.
For better maintainability, consider defining the wolfSSL version as a variable. For consistency with how other arguments like NGTCP2_BRANCH are handled in this file, you could define it as an ARG at the top of the Dockerfile (e.g., ARG WOLFSSL_VERSION=v5.9.0-stable) and then use the variable here (e.g., git clone --depth 1 -b $WOLFSSL_VERSION ...). This would also align with the approach in ci/build_wolfssl.sh, which uses a variable for the version. This makes future updates easier.
1 participant
No description provided.