examples: Adopt std::print in util, debug, and shared#2084
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the codebase by adopting C++23's Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modernizes the example code by replacing C-style fprintf and iostream-based printing with the new C++23 std::print and std::println facilities. This improves type safety and readability, especially with the use of format strings and raw string literals for multi-line output. The changes are well-executed across several files. I found one issue in examples/shared.cc where an incorrect argument is passed to std::println, which will cause a compilation error.
tatsuhiro-t
force-pushed
the
examples-print-util-debug-shared
branch
from
5a2e82c to
34cf5a4
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the example files util.cc, debug.cc, shared.cc and their variants to use std::print and std::println from C++23. This replaces previous uses of fprintf and std::iostream. The changes leverage format strings for type-safe output and raw string literals for multi-line messages. A new helper function, as_string_view, has been added to template.h to allow printing byte spans as strings.
1 participant
No description provided.