Skip to content

examples: Refactor server with std::expected#2082

Merged
tatsuhiro-t merged 1 commit intomainfrom
examples-expected-server
Mar 21, 2026
Merged

examples: Refactor server with std::expected#2082
tatsuhiro-t merged 1 commit intomainfrom
examples-expected-server

Conversation

@tatsuhiro-t
Copy link
Copy Markdown
Member

No description provided.

@tatsuhiro-t tatsuhiro-t added this to the v1.22.0 milestone Mar 21, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant refactoring of the server example's error handling mechanism. By migrating from integer-based error codes to std::expected, the codebase now benefits from explicit and type-safe error propagation. This change enhances readability and maintainability by clearly distinguishing between successful outcomes and various failure modes, which are now precisely defined by an extended Error enum. The refactor touches a broad range of functions, ensuring a consistent and robust error management strategy.

Highlights

  • Error Handling Refactor: Replaced traditional integer-based error codes with std::expected<T, Error> across numerous functions in the server example, providing a more modern and type-safe approach to error propagation.
  • Expanded Error Enum: Introduced new Error enum values in shared.h to precisely categorize various failure conditions, including system calls, library errors (LIBC, HTTP3, QUIC), network states (SEND_BLOCKED, CLOSE_WAIT, RETRY_CONN, DROP_CONN), and token validation issues (UNREADABLE_TOKEN).
  • Consistent Error Propagation: Updated error checking logic from if (rv != 0) or switch statements to if (!rv) and rv.error() for std::expected return types, standardizing error flow throughout the codebase.
  • Function Signature Updates: Modified the return types of over 30 functions in Handler and Server classes from int to std::expected<void, Error>, std::expected<int, Error>, or std::span<const uint8_t> to align with the new error handling paradigm.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a large-scale refactoring to use std::expected for error handling instead of integer return codes. This is a great modernization that improves code clarity and type safety. The changes are applied consistently across the codebase and appear to be correct.

@tatsuhiro-t tatsuhiro-t merged commit 6549d39 into main Mar 21, 2026
73 checks passed
@tatsuhiro-t tatsuhiro-t deleted the examples-expected-server branch March 21, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant