examples: Use std::expected in shared and util#2077
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the error handling strategy within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors several functions in the shared and util libraries to use std::expected for error handling, which is a great improvement for code clarity and safety. The changes are mostly correct and consistently applied across the examples. However, I found a critical bug in make_socket_nonblocking that causes it to always return an error, and another issue where the return value of this function is not checked in create_nonblock_socket. I've added comments with suggestions to fix these issues.
| return std::unexpected{Error::SYSCALL}; | ||
| } | ||
|
|
||
| make_socket_nonblocking(fd); |
There was a problem hiding this comment.
The return value of make_socket_nonblocking is not checked. Since it now returns a std::expected, you should check for an error and handle it appropriately (e.g., by closing the file descriptor and propagating the error).
if (auto res = make_socket_nonblocking(fd); !res) {
close(fd);
return std::unexpected{res.error()};
}
tatsuhiro-t
force-pushed
the
examples-expected-shared-util
branch
from
d209853 to
d2fedc2
Compare
1 participant
No description provided.