Skip to content

Add missing callbacks to callbacks test#2039

Merged
tatsuhiro-t merged 1 commit intomainfrom
update-callbacks-test
Mar 1, 2026
Merged

Add missing callbacks to callbacks test#2039
tatsuhiro-t merged 1 commit intomainfrom
update-callbacks-test

Conversation

@tatsuhiro-t
Copy link
Copy Markdown
Member

@tatsuhiro-t tatsuhiro-t commented Mar 1, 2026

No description provided.

@tatsuhiro-t tatsuhiro-t added this to the v1.22.0 milestone Mar 1, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Mar 1, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the callback testing framework by incorporating recently introduced callback functions into the ngtcp2_callbacks conversion tests. This ensures that the utility functions designed to convert between different versions of the callback structure correctly handle all expected fields, thereby improving the robustness and future compatibility of the callback mechanism.

Highlights

  • New Callback Functions: Added placeholder implementations for recv_stateless_reset2, get_new_connection_id2, and dcid_status2 callback functions within the test file.
  • Callback Conversion Test Updates: Updated test_ngtcp2_callbacks_convert_to_latest and test_ngtcp2_callbacks_convert_to_old to correctly handle NGTCP2_CALLBACKS_V2 and include assertions for the newly added callbacks and begin_path_validation.
  • Callback Structure Sizing: Adjusted the size calculation for the ngtcp2_callbacks structure in conversion tests from NGTCP2_CALLBACKS_V1 to NGTCP2_CALLBACKS_V2 to ensure all fields are copied and asserted correctly.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • tests/ngtcp2_callbacks_test.c
    • Added new static callback functions: recv_stateless_reset2, get_new_connection_id2, and dcid_status2.
    • Updated test_ngtcp2_callbacks_convert_to_latest to include begin_path_validation in srcbuf and adjust memcpy size to NGTCP2_CALLBACKS_V2.
    • Modified assertions in test_ngtcp2_callbacks_convert_to_latest to check for begin_path_validation and assert_null for the new callbacks.
    • Updated test_ngtcp2_callbacks_convert_to_old to initialize new callbacks in src and adjust memcpy size to NGTCP2_CALLBACKS_V2.
    • Modified assertions in test_ngtcp2_callbacks_convert_to_old to check for begin_path_validation and assert_null for the new callbacks.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds test coverage for new callbacks introduced in NGTCP2_CALLBACKS_V3. It adds stub implementations for recv_stateless_reset2, get_new_connection_id2, and dcid_status2. The existing tests for callback version conversion, test_ngtcp2_callbacks_convert_to_latest and test_ngtcp2_callbacks_convert_to_old, have been updated to test conversion from V2 to the latest version (V3). The changes correctly reflect the API version updates and the test logic is sound. No issues were found in this review.

@tatsuhiro-t tatsuhiro-t merged commit 2b3f82e into main Mar 1, 2026
73 checks passed
@tatsuhiro-t tatsuhiro-t deleted the update-callbacks-test branch March 1, 2026 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/tests

Projects

None yet

Milestone

v1.22.0

Development

Successfully merging this pull request may close these issues.

1 participant

@tatsuhiro-t