Conversation
Migrate to new callbacks that use ngtcp2_stateless_reset_token.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the callback infrastructure for handling connection IDs and stateless reset tokens within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request migrates several callback functions to use the new ngtcp2_stateless_reset_token struct instead of a raw uint8_t* pointer for stateless reset tokens. The changes are applied consistently across various example clients, servers, fuzzing targets, and tests. The implementation has been updated to access the token data via token->data and in some test/fuzz files, the code has been modernized to use struct initializers, which improves clarity and safety. The migration appears to be correct and complete.
Migrate to new callbacks that use ngtcp2_stateless_reset_token.