Fix assertion failure without get_new_connection_id#2036
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an assertion failure that could occur during connection initialization in Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes an assertion failure by allowing either the new get_new_connection_id2 callback or the older get_new_connection_id callback to be provided. This is a valid approach for backward compatibility. I have added one comment to suggest a way to make the API contract stricter and avoid potential ambiguity if both callbacks are provided.
| assert(server || callbacks->recv_retry); | ||
| assert(callbacks->rand); | ||
| assert(callbacks->get_new_connection_id); | ||
| assert(callbacks->get_new_connection_id2 || callbacks->get_new_connection_id); |
There was a problem hiding this comment.
To prevent ambiguity if both callbacks are set, it would be clearer to enforce that only one of them is provided. This makes the API contract stricter during the transition period.
assert(!!callbacks->get_new_connection_id2 ^ !!callbacks->get_new_connection_id);
tatsuhiro-t
deleted the
fix-assertion-failure-without-get_new_connection_id
branch
1 participant
Amends b7bfe41