added test case "test_mixed_bin_str" (see issue #281)#282
added test case "test_mixed_bin_str" (see issue #281)#282rwarren wants to merge 2 commits intomsgpack:masterfrom
Conversation
|
Have you checked there are no test about that for now? |
Yes. I could find nothing that explicitly, or properly, checks dealing with mixed bin/str elements in MessagePack protocol stream. More detail... A proper test for this requires:
The closest I could find (that do not meet these criteria) are:
With a lack of an explicit test, I thought one should be added, so I wrote it rather than requested it. Note that I also considered writing a test case with multiple cases (similar to what Also - I renamed the test to better reflect what it does. The original name wasn't great. |
|
Mixed testing should not be necessary. Packing/unpacking does not change internal state of the Packer/Unpacker beyond managing message buffers. As long as each object/token is handled correctly any mix of types will be handled correctly. |
This is to ensure that behaviour referenced in #281 doesn't break in the future.