Use kvm on ubuntu instead of macos to run Android tests#3252
Merged
TimvdLippe merged 6 commits intomockito:mainfrom Jan 27, 2024
Merged
Use kvm on ubuntu instead of macos to run Android tests#3252TimvdLippe merged 6 commits intomockito:mainfrom
TimvdLippe merged 6 commits intomockito:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3252 +/- ##
=========================================
Coverage 85.33% 85.33%
Complexity 2923 2923
=========================================
Files 336 336
Lines 8906 8906
Branches 1108 1108
=========================================
Hits 7600 7600
Misses 1013 1013
Partials 293 293 ☔ View full report in Codecov by Sentry. |
Contributor
|
Awesome, let's try it out! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/ReactiveCircus/android-emulator-runner?tab=readme-ov-file#running-hardware-accelerated-emulators-on-linux-runners
Might fix help with flaky runs (#2892), proof: https://github.com/mockito/mockito/actions/runs/7678518487/job/20928495438
Let's try and merge this, and later revert the workaround for boot if necessary.
Checklist
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>in the description if relevantFixes #<issue number>if relevant