Fixes #3240 : Renamed mockito bom artifact#3251
Merged
TimvdLippe merged 3 commits intomockito:mainfrom Jan 28, 2024
Merged
Conversation
TWiStErRob
reviewed
Jan 27, 2024
subprojects/bom/bom.gradle
Outdated
| project.rootProject.subprojects.forEach { subproject -> | ||
| if (!subproject.name.endsWith("Test") && | ||
| !subproject.name.endsWith("-test") && | ||
| !subproject.name.endsWith("java21-test") && |
Contributor
There was a problem hiding this comment.
The module name needs to change, not the logic, so that the exclusion catches the non-published test module and does NOT publish it in the BOM.
Rename java21 to java21-test in settings.gradle and folder.
Contributor
Author
There was a problem hiding this comment.
Ok. I'll make the required changes.
Contributor
|
Tip: I think you can test this with |
Contributor
|
I'll let @TimvdLippe take it from here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3251 +/- ##
=========================================
Coverage 85.33% 85.33%
Complexity 2923 2923
=========================================
Files 336 336
Lines 8906 8906
Branches 1108 1108
=========================================
Hits 7600 7600
Misses 1013 1013
Partials 293 293 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>in the description if relevantFixes #<issue number>if relevant