Skip to content

Do not log missing signature warning when automatic signature inference is triggered#9039

Merged
jerrylian-db merged 3 commits intomasterfrom
fix_signature_warning
Jul 11, 2023
Merged

Do not log missing signature warning when automatic signature inference is triggered#9039
jerrylian-db merged 3 commits intomasterfrom
fix_signature_warning

Conversation

@jerrylian-db
Copy link
Collaborator

@jerrylian-db jerrylian-db commented Jul 10, 2023

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Now that we have automatic signature inference, the current signals for when to warn users that they did not specific a model signature are no longer accurate. This PR updates the criteria such that both the signature and input_example arguments are empty, i.e. the signature is neither manually specified nor automatically inferred.

How is this patch tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests (describe details, including test results, below)

Manually logged a model with automatic signature inference. Before this PR, the warning was shown. When using this feature branch, the warning was not shown.

Does this PR change the documentation?

  • No. You can skip the rest of this section.
  • Yes. Make sure the changed pages / sections render correctly in the documentation preview.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Signed-off-by: Jerry Liang <[email protected]>
Signed-off-by: Jerry Liang <[email protected]>
@jerrylian-db jerrylian-db self-assigned this Jul 10, 2023
Signed-off-by: Jerry Liang <[email protected]>
@jerrylian-db jerrylian-db requested a review from harupy July 10, 2023 21:11
@github-actions github-actions bot added area/models MLmodel format, model serialization/deserialization, flavors rn/none List under Small Changes in Changelogs. labels Jul 10, 2023
@mlflow-automation
Copy link
Contributor

mlflow-automation commented Jul 10, 2023

Documentation preview for 51c5a14 will be available here when this CircleCI job completes successfully.

More info

Copy link
Member

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jerrylian-db jerrylian-db merged commit 02f08b7 into master Jul 11, 2023
@jerrylian-db jerrylian-db deleted the fix_signature_warning branch July 11, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/models MLmodel format, model serialization/deserialization, flavors rn/none List under Small Changes in Changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants