Skip to content

Add support for listing artifacts in UC model registry artifact repo#8803

Merged
smurching merged 2 commits intomlflow:masterfrom
smurching:uc-models-list-artifacts
Jun 22, 2023
Merged

Add support for listing artifacts in UC model registry artifact repo#8803
smurching merged 2 commits intomlflow:masterfrom
smurching:uc-models-list-artifacts

Conversation

@smurching
Copy link
Collaborator

@smurching smurching commented Jun 21, 2023

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Adds support for listing artifacts in the UC model registry models artifact repo. This API will be leveraged by e.g the feature store client to check whether a model in UC is a feature-store packaged model (check whether it contains a feature-spec.yml)

How is this patch tested?

Updated unit tests. TODO: test API manually.

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests (describe details, including test results, below)

Does this PR change the documentation?

  • No. You can skip the rest of this section.
  • Yes. Make sure the changed pages / sections render correctly in the documentation preview.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Signed-off-by: Sid Murching <[email protected]>
@mlflow-automation
Copy link
Contributor

Documentation preview for 145f730 will be available here when this CircleCI job completes successfully.

More info

@smurching smurching requested review from BenWilson2 and harupy June 21, 2023 23:05
@smurching smurching added the rn/none List under Small Changes in Changelogs. label Jun 21, 2023
Copy link
Member

@BenWilson2 BenWilson2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smurching smurching merged commit 9afd64f into mlflow:master Jun 22, 2023
@justinwei-db
Copy link
Contributor

Verified this works, thanks for the quick fix!

BenWilson2 pushed a commit to BenWilson2/mlflow that referenced this pull request Jul 5, 2023
…lflow#8803)

* Add support for listing UC model artifacts

Signed-off-by: Sid Murching <[email protected]>

* Fix lint

Signed-off-by: Sid Murching <[email protected]>

---------

Signed-off-by: Sid Murching <[email protected]>
BenWilson2 pushed a commit to BenWilson2/mlflow that referenced this pull request Jul 7, 2023
…lflow#8803)

* Add support for listing UC model artifacts

Signed-off-by: Sid Murching <[email protected]>

* Fix lint

Signed-off-by: Sid Murching <[email protected]>

---------

Signed-off-by: Sid Murching <[email protected]>
BenWilson2 pushed a commit that referenced this pull request Jul 7, 2023
…8803)

* Add support for listing UC model artifacts

Signed-off-by: Sid Murching <[email protected]>

* Fix lint

Signed-off-by: Sid Murching <[email protected]>

---------

Signed-off-by: Sid Murching <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rn/none List under Small Changes in Changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants