Support app factory for mlflow server app#8691
Merged
harupy merged 12 commits intomlflow:masterfrom Jun 14, 2023
Merged
Conversation
Contributor
|
Documentation preview for aceb667 will be available here when this CircleCI job completes successfully. More info
|
harupy
force-pushed
the
support-factory-in-auth
branch
from
0157ac1 to
9d6cb8b
Compare
Member
Author
|
cc @gabrielfu |
harupy
commented
Jun 10, 2023
mlflow/server/auth/__init__.py
Outdated
|
|
||
|
|
||
| def _enable_auth(app: Flask): | ||
| def enable_auth(app: Flask = app): |
Member
Author
There was a problem hiding this comment.
The goal is to avoid accidental app mutation. In the original code, touching this module mutates the app. In the new code, it doesn't.
Collaborator
There was a problem hiding this comment.
i think this looks great and is much easier to debug
harupy
changed the title
gabrielfu
reviewed
Jun 12, 2023
mlflow/server/__init__.py
Outdated
| app = f"{__name__}:app" | ||
| else: | ||
| app = _find_app(app_name) | ||
| app = f"{app}()" if _is_factory(app) else app |
Collaborator
There was a problem hiding this comment.
i think waitress needs --call flag and doesn't need the ()
https://flask.palletsprojects.com/en/2.3.x/deploying/waitress/#running
Collaborator
There was a problem hiding this comment.
i got error when running a plugin app
1. Malformed application 'my_auth:create_app()'
Member
Author
There was a problem hiding this comment.
Ok, let's see what happens if we remove () on windows. Pushing a commit.
Collaborator
There was a problem hiding this comment.
yes it's working now after putting --call before app name!
Signed-off-by: harupy <[email protected]>
Signed-off-by: harupy <[email protected]>
Signed-off-by: harupy <[email protected]>
Signed-off-by: harupy <[email protected]>
Signed-off-by: harupy <[email protected]>
Signed-off-by: harupy <[email protected]>
Signed-off-by: harupy <[email protected]>
Signed-off-by: harupy <[email protected]>
Signed-off-by: harupy <[email protected]>
Signed-off-by: harupy <[email protected]>
Signed-off-by: harupy <[email protected]>
Signed-off-by: harupy <[email protected]>
harupy
force-pushed
the
support-factory-in-auth
branch
from
0575404 to
aceb667
Compare
BenWilson2
pushed a commit
to BenWilson2/mlflow
that referenced
this pull request
Jun 16, 2023
* Support app factory in auth Signed-off-by: harupy <[email protected]> * Add return doc Signed-off-by: harupy <[email protected]> * Update _init_server Signed-off-by: harupy <[email protected]> * Add run Signed-off-by: harupy <[email protected]> * Rename factory Signed-off-by: harupy <[email protected]> * Fix failed test Signed-off-by: harupy <[email protected]> * handle windows Signed-off-by: harupy <[email protected]> * Handle windows Signed-off-by: harupy <[email protected]> * Comment Signed-off-by: harupy <[email protected]> * Fix test_build_waitress_command Signed-off-by: harupy <[email protected]> * Refactor _build_gunicorn_command Signed-off-by: harupy <[email protected]> * Fix test_build_waitress_command Signed-off-by: harupy <[email protected]> --------- Signed-off-by: harupy <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
#xxxWhat changes are proposed in this pull request?
Support app factory in auth to avoid undesired app mutation.
How is this patch tested?
Does this PR change the documentation?
Release Notes
Is this a user-facing change?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts: Artifact stores and artifact loggingarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesarea/examples: Example codearea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models: MLmodel format, model serialization/deserialization, flavorsarea/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templatesarea/projects: MLproject format, project running backendsarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra: MLflow Tracking server backendarea/tracking: Tracking Service, tracking client APIs, autologgingInterface
area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows: Windows supportLanguage
language/r: R APIs and clientslanguage/java: Java APIs and clientslanguage/new: Proposals for new client languagesIntegrations
integrations/azure: Azure and Azure ML integrationsintegrations/sagemaker: SageMaker integrationsintegrations/databricks: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notes