Remove error on redundant isolatedModules/verbatimModuleSyntax combination#53611
Conversation
typescript-bot
added
Author: Team
For Uncommitted Bug
|
@typescript-bot cherry-pick to release-5.0 |
|
Heya @andrewbranch, I've started to run the task to cherry-pick this into |
|
Hey @andrewbranch, I've opened #53612 for you. |
Component commits: f0bc7bd Remove error on redundant isolatedModules/verbatimModuleSyntax combination
typescript-bot
added
For Milestone Bug
|
Was there any code in transformModule that can now go away re: unsetting bad combos? |
|
Just for posterity, does this error also break the case I mentioned here? (base config with isolatedModules, extending config sets verbatimModuleSyntax) Because if so, there would probably be no workaround in the absence of this PR. |
Very little, because the combo with
That was never an error, IIUC. I was careful to make it an error to specify the old options on top of the new options but not vice versa. You could extend a config with |
thanks, I wouldn’t have suspected there was asymmetry in the implementation between the “base” options and “extended” options - I figured the two configs were just merged to get the effective config, since that seems the most obvious implementation. |
… that broke when it is set to true. See details here on PR that should fix in next release 5.0.4: microsoft/TypeScript#53611 When 5.0.4 comes out, need to flip isolatedModules back to true Here is details on the issue: microsoft/TypeScript#53601
…e-5.0 (#53612) Co-authored-by: Andrew Branch <[email protected]>
…to release-5.0 (microsoft#53612) Co-authored-by: Andrew Branch <[email protected]>
6 participants
This was intended to drive clarity, but doesn’t seem worth it since it’s caused a few problems.
Fixes #53601