fix(51100): ensure tsserver shuts down when parent process is killed#51107
Merged
Conversation
Loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using IPC channel (
--useNodeIpc) for communicating with tsserver, the child tsserver process did not shut down on parent process disconnecting (for example due to it being killed).Call
exit()on IPC disconnect, same as stdio-based communication does when pipe to the parent process is destroyed.Initially I've moved theexitimplementation fromIOSessionto the baseSessionto avoid having it duplicated inIOSessionandIpcIOSessionbut changed so that implementations are duplicated after @sheetalkamat's comment. It's unfortunate that this creates duplication that could potentially go out of sync. I guess potentially there could be intermediary class that have this shared logic but that might be overkill.EDIT:
IpcIOSessioninheritsIOSessionso we don't have to duplicate it.Fixes #51100