Plugin probe location is higher priority than peer node_modules#51079
Merged
Conversation
sheetalkamat
force-pushed
the
pluginProbeLocations
branch
from
8134936 to
d76fdef
Compare
MartinJohns
reviewed
Oct 6, 2022
| // Search any globally-specified probe paths, then our peer node_modules | ||
| return [ | ||
| ...this.projectService.pluginProbeLocations, | ||
| // ../../.. to walk from X/node_modules/typescript/lib/tsserver.js to X/node_modules/ |
Contributor
There was a problem hiding this comment.
Aren't you walking up three directories here? But from "X/node_modules/typescript/lib/" to "X/node_modules" is only two directories up.
Member
Author
There was a problem hiding this comment.
combinePath makes it X/node_modules/typescript/lib/tsserver.js/../../../ and comes out with X/node_modules/
Note this didnt change as part of this PR.
RyanCavanaugh
approved these changes
Oct 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34616
#34656 fixed this only for global plugins. This fixes for plugins in the config file.