py/objint: Fix comment for true operand in binary op extra cases.#19004
Open
cuiweixie wants to merge 1 commit intomicropython:masterfrom
Open
py/objint: Fix comment for true operand in binary op extra cases.#19004cuiweixie wants to merge 1 commit intomicropython:masterfrom
cuiweixie wants to merge 1 commit intomicropython:masterfrom
Conversation
The comment incorrectly said true acts as 0; the implementation passes small int 1, matching Python bool semantics. Signed-off-by: Weixie Cui <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19004 +/- ##
=======================================
Coverage 98.46% 98.46%
=======================================
Files 176 176
Lines 22784 22784
=======================================
Hits 22435 22435
Misses 349 349 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Code size report: |
Josverl
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrects the comment next to
mp_const_truehandling inmp_obj_int_binary_op_extra_cases: it said true acts as 0, but the code passes small int1, consistent with Python bool semantics.Notes
Trivial comment-only change; no behaviour change.