-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Bump ws from 8.12.0 to 8.17.1 #16495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumps [ws](https://github.com/websockets/ws) from 8.12.0 to 8.17.1. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.12.0...8.17.1) --- updated-dependencies: - dependency-name: ws dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
|
Thanks for making a pull request to jupyterlab! |
|
I'ld like a review on the trick for cc @brichet as you are probably the most knowledgeable dev about that issue. |
|
Thanks @fcollonval for the workaround, it looks good.
|
Co-authored-by: Nicolas Brichet <[email protected]>
|
Is there a reason this wasn't back ported and released in 4.2.3? |
I'm dealing with internal security flags based on this fix, any explanation? |
|
@fcollonval pinging again, since it's been a couple weeks.
|
|
I don't know the answer, but just so that it is not lost, let's ask the bot to try to backport it: @meeseeksdev please backport to 4.2.x |
|
Hey @ajbozarth sorry for the late answer. I did not backport it because this is only a test dependency. It is not part of the frontend application. But scanning tools can not know that 😅 |
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump ws from 8.12.0 to 8.17.1 Bumps [ws](https://github.com/websockets/ws) from 8.12.0 to 8.17.1. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.12.0...8.17.1) --- updated-dependencies: - dependency-name: ws dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * Trick jest to load node variant of ws * Update packages/testing/src/jest-resolver.ts Co-authored-by: Nicolas Brichet <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Frédéric Collonval <[email protected]> Co-authored-by: Frédéric Collonval <[email protected]> Co-authored-by: Nicolas Brichet <[email protected]>
Bumps ws from 8.12.0 to 8.17.1.
Release notes
Sourced from ws's releases.
... (truncated)
Commits
3c56601[dist] 8.17.1e55e510[security] Fix crash when the Upgrade header cannot be read (#2231)6a00029[test] Increase code coverageddfe4a8[perf] Reduce the amount ofcrypto.randomFillSync()callsb73b118[dist] 8.17.029694a5[test] Use thehighWaterMarkvariable934c9d6[ci] Test on node 221817bac[ci] Do not test on node 2196c9b3d[major] Flip the default value ofallowSynchronousEvents(#2221)e5f32c7[fix] Emit at most one event per event loop iteration (#2218)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.