fix(jest-matcher-utils): compare value of inherited getter on test failure (#10167)#14007
Merged
SimenB merged 3 commits intojestjs:mainfrom Mar 20, 2023
Merged
fix(jest-matcher-utils): compare value of inherited getter on test failure (#10167)#14007SimenB merged 3 commits intojestjs:mainfrom
SimenB merged 3 commits intojestjs:mainfrom
Conversation
SimenB
approved these changes
Mar 18, 2023
Member
SimenB
left a comment
SimenB
left a comment
There was a problem hiding this comment.
thanks, this LGTM 👍
could you fix the linting error?
Contributor
Author
|
Sorry, missed that one. Hope it'll pass this time. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Inherited getters were not enumerated by
deepCyclicCopyObjectcausing getters not being replaced with value and the test code to call those getters later on the copied object. If the non-replaced getter depended on other non-copied value, e.g. a private class field the calling code could end up in error while trying to show comparison of the expected and received value on test failures.Fixes #10167
See more detailed analysis under the issue: #10167 (comment)
Test plan
Added a new test case
'copies value of inherited getters'which is failing without the fix but passes after.