util: Outlier detection tracer delegation#10459
Merged
temawi merged 3 commits intogrpc:masterfrom Aug 8, 2023
Merged
Conversation
OutlierDetectionLoadBalancer did not delegate calls to an existing ClientStreamTracer from the tracer it installed. This change has the OD tracer delegate all calls to the underlying one.
sanjaypujare
reviewed
Aug 8, 2023
util/src/test/java/io/grpc/util/OutlierDetectionLoadBalancerTest.java
Outdated
Show resolved
Hide resolved
sanjaypujare
reviewed
Aug 8, 2023
sanjaypujare
suggested changes
Aug 8, 2023
Contributor
sanjaypujare
left a comment
sanjaypujare
left a comment
There was a problem hiding this comment.
Requested another test-case
sanjaypujare
reviewed
Aug 8, 2023
util/src/test/java/io/grpc/util/OutlierDetectionLoadBalancerTest.java
Outdated
Show resolved
Hide resolved
sanjaypujare
approved these changes
Aug 8, 2023
Contributor
sanjaypujare
left a comment
sanjaypujare
left a comment
There was a problem hiding this comment.
LG but it will be good to address the one remaining comment
temawi
added a commit
to temawi/grpc-java
that referenced
this pull request
Aug 15, 2023
OutlierDetectionLoadBalancer did not delegate calls to an existing ClientStreamTracer from the tracer it installed. This change has the OD tracer delegate all calls to the underlying one.
temawi
added a commit
that referenced
this pull request
Aug 15, 2023
larry-safran
pushed a commit
to larry-safran/grpc-java
that referenced
this pull request
Aug 29, 2023
OutlierDetectionLoadBalancer did not delegate calls to an existing ClientStreamTracer from the tracer it installed. This change has the OD tracer delegate all calls to the underlying one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OutlierDetectionLoadBalancer did not delegate calls to an existing ClientStreamTracer from the tracer it installed. This change has the OD tracer delegate all calls to the underlying one.
b/287995936