Add preview_open and preview_close events to Gallery#10303
Merged
freddyaboulton merged 5 commits intomainfrom Jan 8, 2025
Merged
Add preview_open and preview_close events to Gallery#10303freddyaboulton merged 5 commits intomainfrom
freddyaboulton merged 5 commits intomainfrom
Conversation
Collaborator
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/684668a055035bd074125fc3fae80d91cfcfd447/gradio-5.10.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@684668a055035bd074125fc3fae80d91cfcfd447#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/684668a055035bd074125fc3fae80d91cfcfd447/gradio-client-1.9.0.tgzUse Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/684668a055035bd074125fc3fae80d91cfcfd447/dist/lite.js""></script> |
Collaborator
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
freddyaboulton
requested review from
abidlabs,
aliabd,
aliabid94,
dawoodkhan82,
hannahblair and
pngwn
and removed request for
abidlabs and
hannahblair
abidlabs
approved these changes
Jan 8, 2025
Member
abidlabs
left a comment
abidlabs
left a comment
There was a problem hiding this comment.
LGTM @freddyaboulton! Your changes look good, but while testing this PR I noticed that the .change() event of the interactive gr.Gallery component does not fire when files are uploaded, so perhaps we can fix that as part of this PR.
Repro:
import gradio as gr
with gr.Blocks() as demo:
with gr.Row():
g1 = gr.Gallery()
g2 = gr.Gallery()
t = gr.Textbox(interactive=True)
g1.change(lambda x:x, g1, g2)
g2.preview_close(lambda : "hi", None, t)
demo.launch()
Collaborator
Author
|
Thanks for the review @abidlabs ! Took care of that issue and modified the e2e tests to reflect the new behavior. |
dawoodkhan82
pushed a commit
that referenced
this pull request
Jan 13, 2025
* Add preview_open and preview_close events to Gallery * add changeset * notebooks * trigger change when upload --------- Co-authored-by: gradio-pr-bot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #6697
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Testing and Formatting Your Code
PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests:
bash scripts/run_backend_tests.shPlease run these bash scripts to automatically format your code:
bash scripts/format_backend.sh, and (if you made any changes to non-Python files)bash scripts/format_frontend.sh