mount.go (1)

177-178: Remove/format leftover commented code to satisfy linter and avoid noise

The commented‐out declaration //var routePos uint32 has no functional purpose after the route-position logic was removed and is currently triggering gocritic (commentFormatting: put a space between // and comment text).
Either delete the line or keep it properly formatted with a leading space and a short explanation so it does not look like forgotten code.

-	//var routePos uint32
+	// var routePos uint32 // kept for historical reference – delete once route-position tracking is fully removed

🧰 Tools

🪛 GitHub Check: lint

[failure] 177-177:
commentFormatting: put a space between // and comment text (gocritic)

router.go (2)

49-57: Comment style & dead pos field create maintenance debt

1. Comment starts with triple ### which violates Go comment conventions and will be flagged by linters (gocritic, golint).
2. The pos field is now unused since sorting and assignment were deleted. Keeping an unused 8-byte field in every Route instance wastes memory (~0.8 MB per 100 k routes) and confuses future readers.

Consider deleting the field completely (plus all mentions) or at least marking it // deprecated until it is removed.

-	// ### important: always keep in sync with the copy method "app.copyRoute" and all creations of Route struct###
-	pos         uint32      // Position in stack -> important for the sort of the matched routes
+	// NOTE: keep this struct in sync with app.copyRoute and every direct Route initialisation.
+	// Deprecated – `pos` is no longer used after removal of route-sorting logic.
+	// pos uint32 // deprecated

🧰 Tools

🪛 GitHub Check: lint

[failure] 51-51:
field pos is unused (unused)

---

451-466: Duplicate-route merge only checks the last entry – edge cases slip through

addRoute merges handlers when the immediately preceding route matches (app.stack[m][l-1]).
If the same route/path was registered earlier but not in the last position, duplication is silently allowed and the stack grows unnecessarily.

Consider using a map keyed by (path,use,mount) per method or scanning the slice in reverse until the first non-middleware mismatch:

-	l := len(app.stack[m])
-	if l > 0 && app.stack[m][l-1].Path == route.Path && route.use == app.stack[m][l-1].use && !route.mount && !app.stack[m][l-1].mount {
+	for i := len(app.stack[m]) - 1; i >= 0; i-- {
+		prev := app.stack[m][i]
+		if prev.Path == route.Path && prev.use == route.use && !prev.mount && !route.mount {
+			prev.Handlers = append(prev.Handlers, route.Handlers...)
+			return
+		}
+	}

This prevents silent duplication and keeps the stack compact.

router_test.go (1)

514-538: Strengthen new integration test with content assertion

Test_Router_Mount_n_Static only checks the status code.
Adding a quick body assertion ensures we’re not getting a 200 with an unexpected body (e.g., the catch-all middleware).

 resp, err := app.Test(httptest.NewRequest(MethodGet, "/static/style.css", nil))
 utils.AssertEqual(t, nil, err, "app.Test(req)")
 utils.AssertEqual(t, 200, resp.StatusCode, "Status code")
+
+body, err := io.ReadAll(resp.Body)
+utils.AssertEqual(t, nil, err, "read body")
+utils.AssertEqual(t, true, strings.Contains(string(body), "color"), "static file contents")

While at it, you might also assert that /mount/test returns 200 to cover the mounted sub-app.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

router_test.go:537

• Consider adding assertions to verify the response body/content of the static file to ensure the correct file is served.

utils.AssertEqual(t, 200, resp.StatusCode, "Status code")

router_test.go:515

• This test sets up a mounted subapp but doesn't verify requests to the mounted route (/mount/test). Consider adding a request and assertion for the mount endpoint to cover that behavior.

func Test_Router_Mount_n_Static(t *testing.T) {

router.go:450

• The addRoute method signature no longer accepts the isMounted flag, which may cause mounted routes to be treated as non-mounted. Consider restoring the flag or leveraging route.mount to preserve mount semantics.

func (app *App) addRoute(method string, route *Route) {

router.go:435

• [nitpick] Explicitly assigning group: nil is redundant since the zero value is already nil. You can remove this line to reduce noise.

group: nil,