Rust: Update rust/diagnostic/database-quality#21347
Open
geoffw0 wants to merge 3 commits intogithub:mainfrom
Open
Rust: Update rust/diagnostic/database-quality#21347geoffw0 wants to merge 3 commits intogithub:mainfrom
geoffw0 wants to merge 3 commits intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Rust database quality diagnostics by removing the macro call target resolution metric, which was causing false alarms on the tool status page. The metric remains available for telemetry purposes but is no longer used as a diagnostic threshold.
Changes:
- Removed
MacroCallTargetStatsReport::percentageOfOkfrom the database quality diagnostic thresholds - Added a change note documenting the removal and its rationale
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rust/ql/src/queries/telemetry/DatabaseQualityDiagnostics.ql | Removed macro call target resolution metric from diagnostic predicate |
| rust/ql/src/change-notes/2026-02-18-database-quality.md | Added change note documenting the removal of the unreliable metric |
hvitved
reviewed
Feb 19, 2026
hvitved
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
rust/diagnostic/database-quality, removing the macro call target resolution metric. This metric was found to be an unreliable indicator of database quality in many cases, leading to false alarms on the tool status page.