Skip to content

Conversation

@FeodorFitsner
Copy link
Contributor

@FeodorFitsner FeodorFitsner commented Aug 20, 2025

Close #5577

Summary by Sourcery

Bump Flutter requirement to 3.35.1 and update related code and configs

Enhancements:

  • Update theme parsing functions to use Flutter’s AppBarThemeData and BottomAppBarThemeData types
  • Remove custom themesEqual workaround and simplify theme comparison logic
  • Add new project dependency and hashing utilities imports in the flet-cli build command

Build:

  • Raise MINIMAL_FLUTTER_VERSION in flet-cli build script to 3.35.1

CI:

  • Upgrade AppVeyor FLUTTER_VERSION to 3.35.1

Tests:

  • Add integration tests for TextField with label and with label plus value

Chores:

  • Drop flutter/foundation import and remove obsolete .fvmrc file

Bump Flutter version to 3.35.1 in config files and CLI requirements. Refactor theme comparison logic in page.dart and theme.dart, removing custom equality checks. Enhance TextField integration tests by adding new cases and corresponding golden images for macOS. Update dependencies in pubspec.lock.
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 20, 2025

Deploying flet-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7665891
Status: ✅  Deploy successful!
Preview URL: https://819b073e.flet-docs.pages.dev
Branch Preview URL: https://v1-flutter-3-35.flet-docs.pages.dev

View logs

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates Flutter version from 3.32.4/3.32.8 to 3.35.1 across the codebase and makes necessary code adjustments to maintain compatibility with the newer Flutter version.

Key changes:

  • Update Flutter version constraints and CI configurations to 3.35.1
  • Replace deprecated Flutter theme types with their newer equivalents
  • Remove obsolete theme comparison workaround that's no longer needed

Reviewed Changes

Copilot reviewed 8 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sdk/python/packages/flet/integration_tests/controls/test_textfield.py Add new TextField integration tests and rename existing test
sdk/python/packages/flet-cli/src/flet_cli/commands/build.py Update minimal Flutter version requirement and reorganize imports
packages/flet/lib/src/utils/theme.dart Update theme parsing to use newer Flutter types and remove custom theme comparison
packages/flet/lib/src/controls/page.dart Simplify theme comparison using native Flutter equality
client/.fvmrc Remove old Flutter version file
.github/workflows/macos-integration-tests.yml Update path reference for FVM config
.fvmrc Add new Flutter version configuration file
.appveyor.yml Update Flutter version in CI environment

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@FeodorFitsner FeodorFitsner merged commit a43101f into main Aug 20, 2025
4 checks passed
@FeodorFitsner FeodorFitsner deleted the v1-flutter-3-35 branch August 20, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v1: Migrate to Flutter 3.35

3 participants