Skip to content

feat(locale): add Japanese bear definitions#3720

Merged
xDivisionByZerox merged 1 commit intofaker-js:nextfrom
atzzCokeK:feat/ja-animal-bear
Feb 26, 2026
Merged

feat(locale): add Japanese bear definitions#3720
xDivisionByZerox merged 1 commit intofaker-js:nextfrom
atzzCokeK:feat/ja-animal-bear

Conversation

@atzzCokeK
Copy link
Contributor

Summary

Add bear definitions for the Japanese (ja) locale.

Added files

bear.ts - Bear species (10 items)

ヒグマ, ツキノワグマ, ホッキョクグマ, アメリカクロクマ, ハイイログマ, マレーグマ, メガネグマ, ナマケグマ, ジャイアントパンダ, アジアクロクマ

References

Test plan

  • pnpm run generate:locales executed successfully

@netlify
Copy link

netlify bot commented Jan 31, 2026

Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2d88774
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/699fdab3a8c7fe0008d2b31d
😎 Deploy Preview https://deploy-preview-3720.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Jan 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.88%. Comparing base (54af8a8) to head (2d88774).
⚠️ Report is 3 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3720   +/-   ##
=======================================
  Coverage   98.88%   98.88%           
=======================================
  Files         883      883           
  Lines        3061     3061           
  Branches      556      556           
=======================================
  Hits         3027     3027           
  Misses         30       30           
  Partials        4        4           
Files with missing lines Coverage Δ
src/locales/ja/animal/index.ts 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@atzzCokeK atzzCokeK marked this pull request as ready for review February 9, 2026 04:14
@atzzCokeK atzzCokeK requested a review from a team as a code owner February 9, 2026 04:14
matthewmayer
matthewmayer previously approved these changes Feb 9, 2026
Shinigami92
Shinigami92 previously approved these changes Feb 9, 2026
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: animal Something is referring to the animal module labels Feb 25, 2026
ST-DDT
ST-DDT previously approved these changes Feb 25, 2026
@xDivisionByZerox xDivisionByZerox added this to the v10.x milestone Feb 26, 2026
@xDivisionByZerox
Copy link
Member

I'll merge this without a third review or the usual idle time after 2 reviews, since two other team members already approved these changes previously.

@xDivisionByZerox xDivisionByZerox added this pull request to the merge queue Feb 26, 2026
Merged via the queue into faker-js:next with commit 2a4b15c Feb 26, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: locale Permutes locale definitions m: animal Something is referring to the animal module p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants