feat(locale): enhance ta_IN locale with internet, location, and person data#3659
feat(locale): enhance ta_IN locale with internet, location, and person data#3659Pradeepg2445 wants to merge 11 commits intofaker-js:nextfrom
Conversation
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3659 +/- ##
==========================================
- Coverage 99.97% 99.97% -0.01%
==========================================
Files 2994 3037 +43
Lines 236305 237507 +1202
Branches 939 941 +2
==========================================
+ Hits 236248 237448 +1200
- Misses 57 59 +2
🚀 New features to boost your workflow:
|
| generic: [ | ||
| { value: '{{person.last_name.generic}}', weight: 95 }, | ||
| { | ||
| value: '{{person.last_name.generic}}-{{person.last_name.generic}}', |
There was a problem hiding this comment.
Are hyphenated surnames like this common in Tamil?
There was a problem hiding this comment.
Thanks for the review!
Hyphenated surnames are not common in Tamil. I added the pattern only to follow the structure used in some other locales, but I can remove it to keep the data accurate for ta_IN.
I’ll update the PR and push the changes shortly.
There was a problem hiding this comment.
Ok you can make it 100% on the single last name pattern then.
There was a problem hiding this comment.
Thanks again for the review!
I’ve addressed all the pending feedback and pushed the updated changes.
Please let me know if anything else is needed from my side.
…nd color, commerce, and company data
xDivisionByZerox
added
c: feature
3 participants
This PR enhances the
ta_INlocale with the following additions:All changes pass preflight checks and follow the existing locale structure.