Skip to content

refactor: use C++20's contains() method#45814

Merged
codebytere merged 1 commit into34-x-yfrom
refactor/use-std-contains--34-x-y
Feb 27, 2025
Merged

refactor: use C++20's contains() method#45814
codebytere merged 1 commit into34-x-yfrom
refactor/use-std-contains--34-x-y

Conversation

@ckerr
Copy link
Member

@ckerr ckerr commented Feb 26, 2025

Manual backport of #45742 to 34-x-y. See that PR for details.

Notes: none.

* chore: use std::map<>::contains() instead of count() or find()

* chore: use std::map<>::contains() instead of base::Contains()
@ckerr ckerr added backport This is a backport PR semver/patch backwards-compatible bug fixes target/33-x-y PR should also be added to the "33-x-y" branch. labels Feb 26, 2025
@trop trop bot mentioned this pull request Feb 26, 2025
3 tasks
@trop trop bot requested a review from a team February 26, 2025 17:22
@trop trop bot added the 34-x-y label Feb 26, 2025
@felixrieseberg
Copy link
Member

I love how much C++ I learn from you. Nice refactor, so easy to understand!

@ckerr ckerr removed the target/33-x-y PR should also be added to the "33-x-y" branch. label Feb 27, 2025
@codebytere codebytere merged commit b4bb928 into 34-x-y Feb 27, 2025
64 checks passed
@codebytere codebytere deleted the refactor/use-std-contains--34-x-y branch February 27, 2025 09:38
@release-clerk
Copy link

release-clerk bot commented Feb 27, 2025

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

34-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants