Skip to content

Commit fa9f3f5

Browse files
authored
Merge pull request #270 from crazy-max/allow-remote-fs
allow filesystem entitlements by default
2 parents b8df42c + 4c0e3cd commit fa9f3f5

File tree

4 files changed

+16
-5
lines changed

4 files changed

+16
-5
lines changed

.github/workflows/ci.yml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -694,6 +694,13 @@ jobs:
694694

695695
allow:
696696
runs-on: ubuntu-latest
697+
strategy:
698+
fail-fast: false
699+
matrix:
700+
buildx-version:
701+
- v0.19.0-rc2
702+
- v0.18.0
703+
- v0.17.1
697704
steps:
698705
-
699706
name: Checkout
@@ -702,7 +709,7 @@ jobs:
702709
name: Set up Docker Buildx
703710
uses: docker/setup-buildx-action@v3
704711
with:
705-
version: ${{ inputs.buildx-version || env.BUILDX_VERSION }}
712+
version: ${{ matrix.buildx-version }}
706713
driver-opts: |
707714
image=${{ inputs.buildkit-image || env.BUILDKIT_IMAGE }}
708715
-

dist/index.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/context.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,13 @@ async function getBakeArgs(inputs: Inputs, definition: BakeDefinition, toolkit:
8383
args.push(inputs.source);
8484
}
8585
if (await toolkit.buildx.versionSatisfies('>=0.17.0')) {
86-
if (inputs.allow.length > 0) {
87-
args.push('--allow', inputs.allow.join(','));
86+
if (await toolkit.buildx.versionSatisfies('>=0.18.0')) {
87+
// allow filesystem entitlements by default
88+
inputs.allow.push('fs=*');
8889
}
90+
await Util.asyncForEach(inputs.allow, async allow => {
91+
args.push('--allow', allow);
92+
});
8993
}
9094
await Util.asyncForEach(inputs.files, async file => {
9195
args.push('--file', file);

0 commit comments

Comments
 (0)