Skip to content

Make so line number not copied#1717

Merged
nedbat merged 3 commits intocoveragepy:masterfrom
enrh:rh/userselect
Dec 19, 2023
Merged

Make so line number not copied#1717
nedbat merged 3 commits intocoveragepy:masterfrom
enrh:rh/userselect

Conversation

@enrh
Copy link
Contributor

@enrh enrh commented Dec 18, 2023

Within the htmlcov output, there are line numbers for the code. This update makes so when you highlight the code the line numbers are not included.

image

becomes

image

@enrh
Copy link
Contributor Author

enrh commented Dec 18, 2023

Hey Ned,

I saw in https://coverage.readthedocs.io/en/latest/contributing.html that you prefer if people run their idea by you first, but I suspect that is for more complicated changes. I hope that is okay!

@enrh
Copy link
Contributor Author

enrh commented Dec 18, 2023

Dang it! I will work through the errors :)

@nedbat
Copy link
Member

nedbat commented Dec 18, 2023

Thanks for this. Small changes can be very useful. The .css files are generated from .scss files, so the edits should start there. Maybe I need to add more to the .css files to alert people, or to the contributing docs.

@enrh
Copy link
Contributor Author

enrh commented Dec 19, 2023

Maybe I need to add more to the .css files to alert people, or to the contributing docs.

Actually I think it's reasonable that I should have noticed style.scss :) I have updated and run make css for good measure, and it did not change the files I had updated by hand.

@enrh
Copy link
Contributor Author

enrh commented Dec 19, 2023

Maybe I need to add more to the .css files to alert people, or to the contributing docs.

Actually I think it's reasonable that I should have noticed style.scss :) I have updated and run make css for good measure, and it did not change the files I had updated by hand.

Also there is this

coverage/htmlfiles/style.css:/* Don't edit this .css file. Edit the .scss file instead! */

@enrh
Copy link
Contributor Author

enrh commented Dec 19, 2023 •
edited
Loading

I believe the checks failed because of a GitHub backend timeout or something unrelated to the code. Are you able to restart or would you prefer I make a faux commit and then undo the commit?

@nedbat nedbat merged commit 8dc5d3d into coveragepy:master Dec 19, 2023
@nedbat
Copy link
Member

nedbat commented Dec 19, 2023

Thanks!

nedbat added a commit that referenced this pull request Dec 19, 2023
@nedbat
docs: thanks, Robert Harris, for #1717
1a04c58
@enrh enrh deleted the rh/userselect branch December 20, 2023 00:23
@enrh
Copy link
Contributor Author

enrh commented Dec 20, 2023

You are welcome! Thank you!

@nedbat
Copy link
Member

nedbat commented Dec 20, 2023

This is now released as part of coverage 7.3.4.

renovate bot referenced this pull request in allenporter/flux-local Dec 24, 2023
@renovate
chore(deps): update dependency coverage to v7.3.4 (#469)
6865252 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [coverage](https://togithub.com/nedbat/coveragepy) | `==7.3.3` ->
`==7.3.4` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/coverage/7.3.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/coverage/7.3.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/coverage/7.3.3/7.3.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/coverage/7.3.3/7.3.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>nedbat/coveragepy (coverage)</summary>

###
[`v7.3.4`](https://togithub.com/nedbat/coveragepy/blob/HEAD/CHANGES.rst#Version-734--2023-12-20)

[Compare
Source](https://togithub.com/nedbat/coveragepy/compare/7.3.3...7.3.4)

- Fix: the change for multi-line signature exclusions in 7.3.3 broke
other
forms of nested clauses being excluded properly. This is now fixed,
closing
    `issue 1713`\_.

- Fix: in the HTML report, selecting code for copying won't select the
line
    numbers also. Thanks, `Robert Harris <pull 1717_>`\_.

.. \_issue
1713:[https://github.com/nedbat/coveragepy/issues/1713](https://togithub.com/nedbat/coveragepy/issues/1713)3
.. \_pull
1717[https://github.com/nedbat/coveragepy/pull/1717](https://togithub.com/nedbat/coveragepy/pull/1717)17

.. \_changes\_7-3-3:

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/allenporter/flux-local).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@enrh @nedbat