fix: add in all the extra arguments for uploader#955
Merged
thomasrockhu-codecov merged 1 commit intomainfrom Apr 11, 2023
Merged
fix: add in all the extra arguments for uploader#955thomasrockhu-codecov merged 1 commit intomainfrom
thomasrockhu-codecov merged 1 commit intomainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #955 +/- ##
==========================================
+ Coverage 95.32% 96.35% +1.03%
==========================================
Files 4 4
Lines 171 192 +21
Branches 49 56 +7
==========================================
+ Hits 163 185 +22
+ Misses 8 7 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
drazisil-codecov
approved these changes
Apr 11, 2023
3flex
reviewed
Apr 12, 2023
| - uses: actions/checkout@master | ||
| - uses: codecov/codecov-action@v3 | ||
| with: | ||
| token: ${{ secrets.CODECOV_TOKEN }} # not required for public repos |
There was a problem hiding this comment.
Is this a breaking change? Is it now required for public repos?
Contributor
Author
There was a problem hiding this comment.
@3flex this is not a breaking change, but we do suggest using the token when possible to prevent flakiness when hitting the GitHub API
kleisauke
reviewed
Apr 29, 2023
| } | ||
| if (gcovIgnore) { | ||
| execArgs.push('--gcovIgnore', `${gcovIgnore}`); | ||
| execArgs.push('-gcovIgnore', `${gcovIgnore}`); |
Contributor
There was a problem hiding this comment.
This change is incorrect and causes files/directories listed in gcov_ignore to be included (i.e. the whole option is ignored since version 3.1.2).
Only short CLI option names can be specified with a single dash (-) instead of 2 (--), see:
https://github.com/codecov/uploader/blob/cb97e5f75b4bba3afed0b07380d5ab29c34d66be/HELPFILE#L40-L42
https://github.com/codecov/uploader/blob/cb97e5f75b4bba3afed0b07380d5ab29c34d66be/src/helpers/cli.ts#L80-L97
So to fix this, one must specify -gi or --gcovIgnore here.
FWIW, -gcovArgs, -gcovInclude, -gcovExecutable, -networkFilter, -networkPrefix are probably having the same issue.
Contributor
There was a problem hiding this comment.
So to fix this, one must specify
-gior--gcovIgnorehere.
Ah, -gi is also invalid, a single dash is only valid for single character aliases, see:
yargs/yargs#1781 (comment)
So, this issue affects the following settings:
full_report, uses-full, needs to be changed to--fullor--fullReport;gcov_args, uses-gcovArgs, needs to be changed to--gaor--gcovArgs;gcov_ignore, uses-gcovIgnore, needs to be changed to--gior--gcovIgnore;gcov_include, uses-gcovInclude, needs to be changed to--gIor--gcovInclude;gcov_executable, uses-gcovExecutable, needs to be changed to--gxor--gcovExecutable;network_filter, uses-networkFilter, needs to be changed to-ior--networkFilter;networkPrefix, uses-networkPrefix, needs to be changed to-kor--networkPrefix;swift, uses-xs, needs to be changed to--xsor--swift;swift_project, uses-xsp, needs to be changed to--xspor--swiftProject;xcode, uses-xc, needs to be changed to--xcor--xcode;xcode, uses-xp, needs to be changed to--xpor--xcodeArchivePath.
I just opened PR #969 for this.
fuxingloh
referenced
this pull request
in DeFiCh/jellyfishsdk
May 19, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [codecov/codecov-action](https://togithub.com/codecov/codecov-action) | action | patch | `v3.1.1` -> `v3.1.4` | --- ### Release Notes <details> <summary>codecov/codecov-action</summary> ### [`v3.1.4`](https://togithub.com/codecov/codecov-action/releases/tag/v3.1.4): 3.1.4 [Compare Source](https://togithub.com/codecov/codecov-action/compare/v3.1.3...v3.1.4) #### What's Changed - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 18.15.12 to 18.16.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/codecov/codecov-action/pull/970](https://togithub.com/codecov/codecov-action/pull/970) - Fix typo in README.md by [@​hisaac](https://togithub.com/hisaac) in [https://github.com/codecov/codecov-action/pull/967](https://togithub.com/codecov/codecov-action/pull/967) - fix: add back in working dir by [@​thomasrockhu-codecov](https://togithub.com/thomasrockhu-codecov) in [https://github.com/codecov/codecov-action/pull/971](https://togithub.com/codecov/codecov-action/pull/971) - fix: CLI option names for uploader by [@​kleisauke](https://togithub.com/kleisauke) in [https://github.com/codecov/codecov-action/pull/969](https://togithub.com/codecov/codecov-action/pull/969) - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 18.16.3 to 20.1.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/codecov/codecov-action/pull/975](https://togithub.com/codecov/codecov-action/pull/975) - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 20.1.0 to 20.1.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/codecov/codecov-action/pull/979](https://togithub.com/codecov/codecov-action/pull/979) - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 20.1.2 to 20.1.4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/codecov/codecov-action/pull/981](https://togithub.com/codecov/codecov-action/pull/981) - release: 3.1.4 by [@​thomasrockhu-codecov](https://togithub.com/thomasrockhu-codecov) in [https://github.com/codecov/codecov-action/pull/983](https://togithub.com/codecov/codecov-action/pull/983) #### New Contributors - [@​hisaac](https://togithub.com/hisaac) made their first contribution in [https://github.com/codecov/codecov-action/pull/967](https://togithub.com/codecov/codecov-action/pull/967) - [@​kleisauke](https://togithub.com/kleisauke) made their first contribution in [https://github.com/codecov/codecov-action/pull/969](https://togithub.com/codecov/codecov-action/pull/969) **Full Changelog**: codecov/codecov-action@v3.1.3...v3.1.4 ### [`v3.1.3`](https://togithub.com/codecov/codecov-action/releases/tag/v3.1.3): 3.1.3 [Compare Source](https://togithub.com/codecov/codecov-action/compare/v3.1.2...v3.1.3) #### What's Changed - build(deps-dev): bump jest-junit from 15.0.0 to 16.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/codecov/codecov-action/pull/957](https://togithub.com/codecov/codecov-action/pull/957) - build(deps): bump openpgp from 5.7.0 to 5.8.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/codecov/codecov-action/pull/958](https://togithub.com/codecov/codecov-action/pull/958) - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 18.15.10 to 18.15.12 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/codecov/codecov-action/pull/959](https://togithub.com/codecov/codecov-action/pull/959) - fix: allow for aarch64 build by [@​thomasrockhu-codecov](https://togithub.com/thomasrockhu-codecov) in [https://github.com/codecov/codecov-action/pull/960](https://togithub.com/codecov/codecov-action/pull/960) - chore(release): bump to 3.1.3 by [@​thomasrockhu-codecov](https://togithub.com/thomasrockhu-codecov) in [https://github.com/codecov/codecov-action/pull/961](https://togithub.com/codecov/codecov-action/pull/961) **Full Changelog**: codecov/codecov-action@v3.1.2...v3.1.3 ### [`v3.1.2`](https://togithub.com/codecov/codecov-action/releases/tag/v3.1.2): 3.1.2 [Compare Source](https://togithub.com/codecov/codecov-action/compare/v3.1.1...v3.1.2) #### What's Changed - build(deps): bump node-fetch from 3.2.4 to 3.2.10 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/codecov/codecov-action/pull/835](https://togithub.com/codecov/codecov-action/pull/835) - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 16.11.40 to 18.13.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/codecov/codecov-action/pull/911](https://togithub.com/codecov/codecov-action/pull/911) - build(deps-dev): bump [@​vercel/ncc](https://togithub.com/vercel/ncc) from 0.34.0 to 0.36.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/codecov/codecov-action/pull/900](https://togithub.com/codecov/codecov-action/pull/900) - build(deps-dev): bump typescript from 4.7.4 to 4.9.5 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/codecov/codecov-action/pull/905](https://togithub.com/codecov/codecov-action/pull/905) - Update README.md by [@​stefanomunarini](https://togithub.com/stefanomunarini) in [https://github.com/codecov/codecov-action/pull/718](https://togithub.com/codecov/codecov-action/pull/718) - build(deps): bump openpgp from 5.4.0 to 5.5.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/codecov/codecov-action/pull/819](https://togithub.com/codecov/codecov-action/pull/819) - build(deps): bump ossf/scorecard-action from 1.1.1 to 2.0.4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/codecov/codecov-action/pull/840](https://togithub.com/codecov/codecov-action/pull/840) - build(deps): bump [@​actions/core](https://togithub.com/actions/core) from 1.9.1 to 1.10.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/codecov/codecov-action/pull/841](https://togithub.com/codecov/codecov-action/pull/841) - build(deps): bump [@​actions/github](https://togithub.com/actions/github) from 5.0.3 to 5.1.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/codecov/codecov-action/pull/843](https://togithub.com/codecov/codecov-action/pull/843) - build(deps): bump actions/upload-artifact from 3.1.0 to 3.1.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/codecov/codecov-action/pull/896](https://togithub.com/codecov/codecov-action/pull/896) - build(deps-dev): bump jest-junit from 13.2.0 to 15.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/codecov/codecov-action/pull/872](https://togithub.com/codecov/codecov-action/pull/872) - build(deps): bump node-fetch from 3.2.10 to 3.3.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/codecov/codecov-action/pull/869](https://togithub.com/codecov/codecov-action/pull/869) - build(deps): bump decode-uri-component from 0.2.0 to 0.2.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/codecov/codecov-action/pull/879](https://togithub.com/codecov/codecov-action/pull/879) - build(deps): bump json5 from 2.2.1 to 2.2.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/codecov/codecov-action/pull/895](https://togithub.com/codecov/codecov-action/pull/895) - codeql-analysis.yml by [@​minumulasri](https://togithub.com/minumulasri) in [https://github.com/codecov/codecov-action/pull/898](https://togithub.com/codecov/codecov-action/pull/898) - build(deps): bump ossf/scorecard-action from 1.1.1 to 2.1.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/codecov/codecov-action/pull/889](https://togithub.com/codecov/codecov-action/pull/889) - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 18.13.0 to 18.14.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/codecov/codecov-action/pull/922](https://togithub.com/codecov/codecov-action/pull/922) - build(deps): bump openpgp from 5.5.0 to 5.7.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/codecov/codecov-action/pull/924](https://togithub.com/codecov/codecov-action/pull/924) - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 18.14.0 to 18.14.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/codecov/codecov-action/pull/927](https://togithub.com/codecov/codecov-action/pull/927) - Remove unsupported path_to_write_report argument by [@​jsoref](https://togithub.com/jsoref) in [https://github.com/codecov/codecov-action/pull/851](https://togithub.com/codecov/codecov-action/pull/851) - Update README to contain correct information - inputs and negate feature by [@​moshe-azaria-sage](https://togithub.com/moshe-azaria-sage) in [https://github.com/codecov/codecov-action/pull/901](https://togithub.com/codecov/codecov-action/pull/901) - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 18.14.2 to 18.14.6 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/codecov/codecov-action/pull/933](https://togithub.com/codecov/codecov-action/pull/933) - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 18.14.6 to 18.15.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/codecov/codecov-action/pull/937](https://togithub.com/codecov/codecov-action/pull/937) - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 18.15.0 to 18.15.5 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/codecov/codecov-action/pull/945](https://togithub.com/codecov/codecov-action/pull/945) - build(deps): bump node-fetch from 3.3.0 to 3.3.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/codecov/codecov-action/pull/938](https://togithub.com/codecov/codecov-action/pull/938) - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 18.15.5 to 18.15.6 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/codecov/codecov-action/pull/946](https://togithub.com/codecov/codecov-action/pull/946) - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 18.15.6 to 18.15.10 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/codecov/codecov-action/pull/947](https://togithub.com/codecov/codecov-action/pull/947) - build(deps): bump ossf/scorecard-action from 2.1.2 to 2.1.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/codecov/codecov-action/pull/951](https://togithub.com/codecov/codecov-action/pull/951) - fix: add in all the extra arguments for uploader by [@​thomasrockhu-codecov](https://togithub.com/thomasrockhu-codecov) in [https://github.com/codecov/codecov-action/pull/955](https://togithub.com/codecov/codecov-action/pull/955) - chore(release): bump to 3.1.2 by [@​thomasrockhu-codecov](https://togithub.com/thomasrockhu-codecov) in [https://github.com/codecov/codecov-action/pull/956](https://togithub.com/codecov/codecov-action/pull/956) #### New Contributors - [@​stefanomunarini](https://togithub.com/stefanomunarini) made their first contribution in [https://github.com/codecov/codecov-action/pull/718](https://togithub.com/codecov/codecov-action/pull/718) - [@​minumulasri](https://togithub.com/minumulasri) made their first contribution in [https://github.com/codecov/codecov-action/pull/898](https://togithub.com/codecov/codecov-action/pull/898) - [@​jsoref](https://togithub.com/jsoref) made their first contribution in [https://github.com/codecov/codecov-action/pull/851](https://togithub.com/codecov/codecov-action/pull/851) - [@​moshe-azaria-sage](https://togithub.com/moshe-azaria-sage) made their first contribution in [https://github.com/codecov/codecov-action/pull/901](https://togithub.com/codecov/codecov-action/pull/901) **Full Changelog**: codecov/codecov-action@v3.1.1...v3.1.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/JellyfishSDK/jellyfish). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS41Ny4wIiwidXBkYXRlZEluVmVyIjoiMzUuNzkuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
ahadas
added a commit
to kubev2v/forklift
that referenced
this pull request
Feb 4, 2024
It's recommended now to set a token for uploading the report to codecov.io as per codecov/codecov-action#955 Also set fail_ci_if_error to 'true' as this action should be stable now. Signed-off-by: Arik Hadas <[email protected]>
ahadas
added a commit
to kubev2v/forklift
that referenced
this pull request
Feb 4, 2024
It's recommended now to set a token for uploading the report to codecov.io as per codecov/codecov-action#955 Also set fail_ci_if_error to 'true' as this action should be stable now. Signed-off-by: Arik Hadas <[email protected]>
This was referenced Feb 23, 2024
Closed
Closed
Closed
Closed
This was referenced Feb 23, 2024
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.