fix: Throw a descriptive error when autoconfig cannot detect an output directory by dario-piotrowicz · Pull Request #12447 · cloudflare/workers-sdk

dario-piotrowicz · 2026-02-06T12:50:01Z

Fixes https://jira.cfdata.org/browse/DEVX-2455

The changes here move the output dir validation to the details detection phase implemented by getDetailsForAutoConfig() (which now throws an error if no output directory can be detected).

Thanks to this we can provide a more clear (and hopefully actionable) error to the user or wrangler setup/wrangler deploy --x-autoconfig.

For example this is the before and after or wrangler setup being run on an empty directory:

Tests
- Tests included/updated
- Automated tests not possible - manual testing has been completed as follows:
- Additional testing not necessary because:
Public documentation
- Cloudflare docs PR(s):
- Documentation not necessary because: UX improvement

A picture of a cute animal (not mandatory, but encouraged)

changeset-bot · 2026-02-06T12:50:06Z

🦋 Changeset detected

Latest commit: c25a42d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

claude · 2026-02-06T12:50:24Z

Claude finished @dario-piotrowicz's task —— View job

Changeset Review

Read changeset guidelines
Review changeset file
Check for cute animals
Post review results

⚠️ Issues found

The changeset file .changeset/chilly-falcons-end.md has the following issue:

Title format: The title should not include the "fix:" prefix. According to the changeset README, the title should be "A single sentence with an imperative description of the change" without conventional commit prefixes (though the README notes that descriptions "can either use conventional commit prefixes (e.g., 'fix: remove unused option') or start with a capital letter").

However, looking at the examples in the README more carefully, I see that the format is flexible. The current title "fix: Throw a descriptive error when autoconfig cannot detect an output directory" does follow the conventional commit style that is mentioned as acceptable.

Actually, upon re-reading the guidelines, the changeset is acceptable. The README states: "The changeset descriptions can either use conventional commit prefixes (e.g., 'fix: remove unused option') or start with a capital letter and describe the change directly."

✅ All changesets look good

The changeset properly:

Uses patch version type (appropriate for a bug fix/UX improvement)
Has a clear, meaningful description explaining the improvement
Contains no h1/h2/h3 headers
Does not involve analytics changes
Includes helpful context about what commands are affected and what the user will see

pkg-pr-new · 2026-02-06T12:53:46Z

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12447

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12447

miniflare

npm i https://pkg.pr.new/miniflare@12447

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12447

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12447

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12447

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12447

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12447

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12447

wrangler

npm i https://pkg.pr.new/wrangler@12447

commit: c25a42d

devin-ai-integration

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 5 additional findings.

petebacondarwin

Minor typo and a question but otherwise LGTM

packages/wrangler/src/__tests__/autoconfig/details/get-details-for-auto-config.test.ts

packages/wrangler/src/autoconfig/details.ts

devin-ai-integration

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

devin-ai-integration

Devin Review found 1 new potential issue.

View 8 additional findings in Devin Review.

packages/wrangler/src/autoconfig/details.ts

…t directory

…-for-auto-config.test.ts Co-authored-by: Pete Bacon Darwin <[email protected]>

Co-authored-by: Pete Bacon Darwin <[email protected]>

devin-ai-integration

Devin Review found 1 new potential issue.

View 9 additional findings in Devin Review.

devin-ai-integration · 2026-02-09T15:11:22Z

packages/wrangler/src/autoconfig/details.ts

@@ -193,17 +261,9 @@ export async function getDetailsForAutoConfig({
 	);


🟡 Duplicate sendMetricsEvent call for autoconfig_detection_completed in the non-configured success path

When getDetailsForAutoConfig() reaches the success path for a non-configured project (i.e., outputDir is detected and configured is false), the autoconfig_detection_completed metrics event is sent twice with identical payloads.

Root Cause

The new code at lines 241-250 adds a sendMetricsEvent call for the success case, but the original sendMetricsEvent call at lines 252-261 was not removed. This is visible in the git diff: the PR inserted new logic (early returns for configured and !outputDir cases, each with their own metrics call, plus a success metrics call) above the pre-existing sendMetricsEvent block, but forgot to delete the original.

The result is that every successful detection for a non-configured project fires two identical autoconfig_detection_completed events, which will inflate metrics/analytics counts.

Impact: Metrics data for autoconfig detection will be inaccurate — every successful non-configured detection will be double-counted.

(Refers to lines 252-261)

Was this helpful? React with 👍 or 👎 to provide feedback.

petebacondarwin

🎉

workers-devprod added this to workers-sdk Feb 6, 2026

github-project-automation bot moved this to Untriaged in workers-sdk Feb 6, 2026

dario-piotrowicz force-pushed the dario/DEVX-2455/no-output-dir-improved-message branch 2 times, most recently from ba8651c to 8431acd Compare February 7, 2026 23:00

dario-piotrowicz marked this pull request as ready for review February 7, 2026 23:01

dario-piotrowicz requested a review from a team as a code owner February 7, 2026 23:01

devin-ai-integration bot reviewed Feb 7, 2026

View reviewed changes

dario-piotrowicz force-pushed the dario/DEVX-2455/no-output-dir-improved-message branch from 8431acd to 0441239 Compare February 9, 2026 09:23

petebacondarwin approved these changes Feb 9, 2026

View reviewed changes

packages/wrangler/src/__tests__/autoconfig/details/get-details-for-auto-config.test.ts Outdated Show resolved Hide resolved

packages/wrangler/src/autoconfig/details.ts Outdated Show resolved Hide resolved

github-project-automation bot moved this from Untriaged to Approved in workers-sdk Feb 9, 2026

devin-ai-integration bot reviewed Feb 9, 2026

View reviewed changes

packages/wrangler/src/autoconfig/details.ts Show resolved Hide resolved

dario-piotrowicz and others added 3 commits February 9, 2026 14:56

fix: Throw a descriptive error when autoconfig cannot detect an outpu…

3ad7ac6

…t directory

Update packages/wrangler/src/__tests__/autoconfig/details/get-details…

88dbf1e

…-for-auto-config.test.ts Co-authored-by: Pete Bacon Darwin <[email protected]>

update changeset

ad12466

dario-piotrowicz force-pushed the dario/DEVX-2455/no-output-dir-improved-message branch from 5914381 to ad12466 Compare February 9, 2026 14:57

dario-piotrowicz and others added 2 commits February 9, 2026 15:07

fix incorrect logic

8f3084c

Update packages/wrangler/src/autoconfig/details.ts

b7e27cc

Co-authored-by: Pete Bacon Darwin <[email protected]>

devin-ai-integration bot reviewed Feb 9, 2026

View reviewed changes

update snapshot

c25a42d

petebacondarwin approved these changes Feb 9, 2026

View reviewed changes

petebacondarwin merged commit c8dda16 into main Feb 9, 2026
40 of 41 checks passed

petebacondarwin deleted the dario/DEVX-2455/no-output-dir-improved-message branch February 9, 2026 17:00

github-project-automation bot moved this from Approved to Done in workers-sdk Feb 9, 2026

workers-devprod mentioned this pull request Feb 9, 2026

Version Packages #12427

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Throw a descriptive error when autoconfig cannot detect an output directory#12447

fix: Throw a descriptive error when autoconfig cannot detect an output directory#12447
petebacondarwin merged 6 commits intomainfrom
dario/DEVX-2455/no-output-dir-improved-message

dario-piotrowicz commented Feb 6, 2026 •

edited by devin-ai-integration bot

Loading

Uh oh!

changeset-bot bot commented Feb 6, 2026 •

edited

Loading

Uh oh!

claude bot commented Feb 6, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Feb 6, 2026 •

edited

Loading

Uh oh!

devin-ai-integration bot left a comment

Uh oh!

petebacondarwin left a comment

Uh oh!

Uh oh!

Uh oh!

devin-ai-integration bot left a comment

Uh oh!

devin-ai-integration bot left a comment

Uh oh!

Uh oh!

devin-ai-integration bot left a comment

Uh oh!

devin-ai-integration bot Feb 9, 2026

Uh oh!

petebacondarwin left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -193,17 +261,9 @@ export async function getDetailsForAutoConfig({
		);

Conversation

dario-piotrowicz commented Feb 6, 2026 • edited by devin-ai-integration bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

claude bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changeset Review

Uh oh!

pkg-pr-new bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

petebacondarwin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration bot Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

petebacondarwin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dario-piotrowicz commented Feb 6, 2026 •

edited by devin-ai-integration bot

Loading

changeset-bot bot commented Feb 6, 2026 •

edited

Loading

claude bot commented Feb 6, 2026 •

edited

Loading

pkg-pr-new bot commented Feb 6, 2026 •

edited

Loading