Skip to content

Fix pnpm 10 publishing with npm 12 - #2276

Merged
Andarist merged 3 commits into
mainfrom
pnpm-npm12-publishing
Sep 14, 2026
Merged

Andarist merged 3 commits into
mainfrom
pnpm-npm12-publishing

Conversation

@Andarist

Copy link
Copy Markdown
Member

fixes #2274

@netlify

netlify Bot commented Aug 29, 2026

Copy link
Copy Markdown

Deploy Preview for changesets ready!

Name Link
🔨 Latest commit 78679fa
🔍 Latest deploy log https://app.netlify.com/projects/changesets/deploys/6aa7cf944948950008396975
😎 Deploy Preview https://deploy-preview-2276--changesets.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@changeset-bot

changeset-bot Bot commented Aug 29, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 78679fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@changesets/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov

codecov Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 55.88235% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.40%. Comparing base (b430ce0) to head (78679fa).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ackages/cli/src/commands/publish/getPublishTool.ts 0.00% 8 Missing ⚠️
packages/cli/src/lib/pnpm.ts 73.91% 4 Missing and 2 partials ⚠️
packages/cli/src/lib/npm.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2276      +/-   ##
==========================================
+ Coverage   86.68%   87.40%   +0.71%     
==========================================
  Files          78       78              
  Lines        2937     2954      +17     
  Branches      831      843      +12     
==========================================
+ Hits         2546     2582      +36     
+ Misses        347      337      -10     
+ Partials       44       35       -9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread packages/cli/src/lib/pnpm.ts Outdated
@Andarist
Andarist force-pushed the pnpm-npm12-publishing branch 9 times, most recently from 6ca021d to e1f2357 Compare September 14, 2026 10:13
@Andarist
Andarist marked this pull request as ready for review September 14, 2026 10:27
@Andarist
Andarist force-pushed the pnpm-npm12-publishing branch from e1f2357 to 611d4a5 Compare September 14, 2026 10:28
@Andarist
Andarist force-pushed the pnpm-npm12-publishing branch from 611d4a5 to 85154fb Compare September 14, 2026 10:33
@Andarist
Andarist requested review from beeequeue and bluwy September 14, 2026 10:36
@bluwy

bluwy commented Sep 14, 2026

Copy link
Copy Markdown
Member

I think eventually we should have each tool handle the major version internally itself, but this is also fine for now

@Andarist
Andarist added this pull request to the merge queue Sep 14, 2026
@Andarist

Copy link
Copy Markdown
Member Author

I think eventually we should have each tool handle the major version internally itself, but this is also fine for now

yeah, I mainly went with this approach to avoid refactoring things. Those tools are not stateful right now and I didn't want to recheck the version on each "method" invocation

Merged via the queue into main with commit ca9d110 Sep 14, 2026
18 of 19 checks passed
@Andarist
Andarist deleted the pnpm-npm12-publishing branch September 14, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pnpm.ts's parseInfoResult doesn't unwrap npm 12's array-wrapped

3 participants